Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: services/dart/test/echo/main.dart

Issue 982673002: Dart: Removes need to call listen(). (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Merge and Format Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/dart/dart_apptests/pingpong_apptests.dart ('k') | services/dart/test/pingpong/main.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/dart/test/echo/main.dart
diff --git a/services/dart/test/echo/main.dart b/services/dart/test/echo/main.dart
index 5d32fb2bff9cfe9c2e5c760c64a058b2c69bdd52..91dd89b29b70ff42caf1d588fe79c1d66b97432a 100644
--- a/services/dart/test/echo/main.dart
+++ b/services/dart/test/echo/main.dart
@@ -13,9 +13,8 @@ class EchoServiceImpl implements EchoService {
EchoServiceStub _stub;
Application _application;
- EchoServiceImpl(Application application, MojoMessagePipeEndpoint endpoint)
- : _application = application {
- _stub = new EchoServiceStub.fromEndpoint(endpoint, impl: this);
+ EchoServiceImpl(this._application, MojoMessagePipeEndpoint endpoint) {
+ _stub = new EchoServiceStub.fromEndpoint(endpoint, this);
}
echoString(String value, Function responseFactory) {
@@ -33,9 +32,7 @@ class EchoApplication extends Application {
void acceptConnection(String requestorUrl, String resolvedUrl,
ApplicationConnection connection) {
connection.provideService(
- EchoServiceName,
- (endpoint) => new EchoServiceImpl(this, endpoint));
- connection.listen();
+ EchoServiceName, (endpoint) => new EchoServiceImpl(this, endpoint));
}
}
« no previous file with comments | « services/dart/dart_apptests/pingpong_apptests.dart ('k') | services/dart/test/pingpong/main.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698