Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1907)

Unified Diff: services/dart/test/pingpong/main.dart

Issue 982673002: Dart: Removes need to call listen(). (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Merge and Format Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/dart/test/echo/main.dart ('k') | services/dart/test/pingpong_target/main.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/dart/test/pingpong/main.dart
diff --git a/services/dart/test/pingpong/main.dart b/services/dart/test/pingpong/main.dart
index 9f7485d74bca8b3ab7f03b2414ffdba5c9ef212d..5c10d354e18ee8c50b0931dc549a9a6d7c1341ab 100644
--- a/services/dart/test/pingpong/main.dart
+++ b/services/dart/test/pingpong/main.dart
@@ -32,17 +32,14 @@ class PingPongServiceImpl implements PingPongService {
Application _application;
PingPongClientProxy _pingPongClient;
- PingPongServiceImpl(Application application, MojoMessagePipeEndpoint endpoint)
- : _application = application {
- _stub = new PingPongServiceStub.fromEndpoint(endpoint, impl: this);
+ PingPongServiceImpl(this._application, MojoMessagePipeEndpoint endpoint) {
+ _stub = new PingPongServiceStub.fromEndpoint(endpoint, this);
}
PingPongServiceImpl.fromStub(this._stub) {
_stub.impl = this;
}
- listen() => _stub.listen();
-
void setClient(ProxyBase proxyBase) {
assert(_pingPongClient == null);
_pingPongClient = proxyBase;
@@ -64,7 +61,6 @@ class PingPongServiceImpl implements PingPongService {
var pingPongClient = new PingPongClientImpl.unbound(count, completer);
pingPongService.ptr.setClient(pingPongClient.stub);
- pingPongClient.stub.listen();
for (var i = 0; i < count; i++) {
pingPongService.ptr.ping(i);
@@ -76,13 +72,12 @@ class PingPongServiceImpl implements PingPongService {
return responseFactory(true);
}
- Future pingTargetService(ProxyBase proxyBase, int count,
- Function responseFactory) async {
+ Future pingTargetService(
+ ProxyBase proxyBase, int count, Function responseFactory) async {
var pingPongService = proxyBase;
var completer = new Completer();
var client = new PingPongClientImpl.unbound(count, completer);
pingPongService.ptr.setClient(client.stub);
- client.stub.listen();
for (var i = 0; i < count; i++) {
pingPongService.ptr.ping(i);
@@ -95,7 +90,7 @@ class PingPongServiceImpl implements PingPongService {
}
getPingPongService(PingPongServiceStub serviceStub) {
- new PingPongServiceImpl.fromStub(serviceStub)..listen();
+ new PingPongServiceImpl.fromStub(serviceStub);
}
void quit() {
@@ -114,10 +109,8 @@ class PingPongApplication extends Application {
@override
void acceptConnection(String requestorUrl, String resolvedUrl,
ApplicationConnection connection) {
- connection.provideService(
- PingPongServiceName,
+ connection.provideService(PingPongServiceName,
(endpoint) => new PingPongServiceImpl(this, endpoint));
- connection.listen();
}
}
« no previous file with comments | « services/dart/test/echo/main.dart ('k') | services/dart/test/pingpong_target/main.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698