Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 982663002: Rearrange PNaCl OnNexeTempFileReply file check to be *before* transferring ownership. (Closed)

Created:
5 years, 9 months ago by jvoung (off chromium)
Modified:
5 years, 9 months ago
Reviewers:
Derek Schuff
CC:
chromium-reviews, Nick Bray (chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rearrange PNaCl OnNexeTempFileReply file check to be *before* transferring ownership. Otherwise, after transferring ownership the old base_file will always be invalid and we get spurious error logs, which can be confusing. This started happening after the refactoring in r274783. https://codereview.chromium.org/307173002/diff/80001/components/nacl/renderer/pnacl_translation_resource_host.cc Alternatively, could have checked the file_handle variable that ends up owning the base_file at the later point, but might as well check it earlier. BUG=none (but it bugged ncbray =)) Committed: https://crrev.com/3ea468bb44663b2bad85c7fd31be6caaf24f7fc4 Cr-Commit-Position: refs/heads/master@{#319170}

Patch Set 1 #

Patch Set 2 : narrow scope of variables #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M components/nacl/renderer/pnacl_translation_resource_host.cc View 1 1 chunk +11 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jvoung (off chromium)
5 years, 9 months ago (2015-03-04 23:07:47 UTC) #2
Derek Schuff
lgtm
5 years, 9 months ago (2015-03-04 23:42:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/982663002/20001
5 years, 9 months ago (2015-03-04 23:57:20 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-05 00:14:58 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 00:15:39 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3ea468bb44663b2bad85c7fd31be6caaf24f7fc4
Cr-Commit-Position: refs/heads/master@{#319170}

Powered by Google App Engine
This is Rietveld 408576698