DescriptionRearrange PNaCl OnNexeTempFileReply file check to be *before* transferring ownership.
Otherwise, after transferring ownership the old
base_file will always be invalid and we get spurious
error logs, which can be confusing.
This started happening after the refactoring in r274783.
https://codereview.chromium.org/307173002/diff/80001/components/nacl/renderer/pnacl_translation_resource_host.cc
Alternatively, could have checked the file_handle variable that
ends up owning the base_file at the later point, but might as
well check it earlier.
BUG=none
(but it bugged ncbray =))
Committed: https://crrev.com/3ea468bb44663b2bad85c7fd31be6caaf24f7fc4
Cr-Commit-Position: refs/heads/master@{#319170}
Patch Set 1 #Patch Set 2 : narrow scope of variables #Messages
Total messages: 7 (2 generated)
|