Rearrange PNaCl OnNexeTempFileReply file check to be *before* transferring ownership.

components/nacl/renderer/pnacl_translation_resource_host.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "pnacl_translation_resource_host.h"
 
 #include "components/nacl/common/nacl_host_messages.h"
 #include "ppapi/c/pp_errors.h"
 #include "ppapi/shared_impl/ppapi_globals.h"
 
@@ skipping 98 matching lines @@
                                                           PP_ToBool(success)));
 }
 
 void PnaclTranslationResourceHost::OnNexeTempFileReply(
     PP_Instance instance,
     bool is_hit,
     IPC::PlatformFileForTransit file) {
   DCHECK(io_message_loop_->BelongsToCurrentThread());
   base::File base_file = IPC::PlatformFileForTransitToFile(file);
   CacheRequestInfoMap::iterator it = pending_cache_requests_.find(instance);
-  int32_t status = PP_ERROR_FAILED;
-  // Handle the expected successful case first.
-  PP_FileHandle file_handle = PP_kInvalidFileHandle;
-  if (it != pending_cache_requests_.end() && base_file.IsValid()) {
-    file_handle = base_file.TakePlatformFile();
-    status = PP_OK;
+  if (!base_file.IsValid()) {
+    DLOG(ERROR) << "Got invalid platformfilefortransit";
   }
-  if (it == pending_cache_requests_.end()) {
-    DLOG(ERROR) << "Could not find pending request for reply";
-  } else {
+  if (it != pending_cache_requests_.end()) {
+    PP_FileHandle file_handle = PP_kInvalidFileHandle;
+    int32_t status = PP_ERROR_FAILED;
+    if (base_file.IsValid()) {
+      file_handle = base_file.TakePlatformFile();
+      status = PP_OK;
+    }
     PpapiGlobals::Get()->GetMainThreadMessageLoop()->PostTask(
         FROM_HERE,
         base::Bind(it->second, status, is_hit, file_handle));
     pending_cache_requests_.erase(it);
-  }
-  if (!base_file.IsValid()) {
-    DLOG(ERROR) << "Got invalid platformfilefortransit";
+  } else {
+    DLOG(ERROR) << "Could not find pending request for reply";
   }
 }
 
 void PnaclTranslationResourceHost::CleanupCacheRequests() {
   DCHECK(io_message_loop_->BelongsToCurrentThread());
   for (CacheRequestInfoMap::iterator it = pending_cache_requests_.begin();
        it != pending_cache_requests_.end();
        ++it) {
     PpapiGlobals::Get()->GetMainThreadMessageLoop()->PostTask(
         FROM_HERE,
         base::Bind(it->second,
                    static_cast<int32_t>(PP_ERROR_ABORTED),
                    false,
                    PP_kInvalidFileHandle));
   }
   pending_cache_requests_.clear();
 }