[Contextual Search] Update promo look.

Contextual Search] Update promo look.

This CL updates the asset for the promo's image, and updates
the promo styles to conform with the new design spec.

See bug report for complete design spec and mocks.

BUG=441476
Committed: https://crrev.com/a4c0df0e847dc9ffc0f3e26a47ac70b53a330513
Cr-Commit-Position: refs/heads/master@{#322045}

[pedro (no code reviews), 2015-03-04 22:46:57]

pedrosimonetti@chromium.org changed reviewers:
+ donnd@chromium.org

[pedro (no code reviews), 2015-03-04 22:47:11]

Hey Donn, please take a look at this change.

[Donn Denman, 2015-03-04 23:01:47]

On 2015/03/04 22:47:11, pedrosimonetti wrote:
> Hey Donn, please take a look at this change.

LGTM!

Can you just verify that it's fine to no longer have an svg image?

[pedro (no code reviews), 2015-03-04 23:33:46]

On 2015/03/04 23:01:47, Donn Denman wrote:
> On 2015/03/04 22:47:11, pedrosimonetti wrote:
> > Hey Donn, please take a look at this change.
> 
> LGTM!
> 
> Can you just verify that it's fine to no longer have an svg image?

It's fine removing the svg, since we'll be using png instead. We need to add
assets in a separate change though, so I just created
https://codereview.chromium.org/978063002/

[pedro (no code reviews), 2015-03-05 03:37:30]

pedrosimonetti@chromium.org changed reviewers:
+ mathp@chromium.org

[pedro (no code reviews), 2015-03-05 03:38:50]

Hey Mathieu, this is a followup CL for the one that just adds the new image for
the promo. This CL uses those images and updates the style of the promo to
conform with the new specs. Could you please take a look at this change too?

[Mathieu, 2015-03-05 13:52:18]

lgtm

[pedro (no code reviews), 2015-03-05 21:49:31]

pedrosimonetti@chromium.org changed reviewers:
+ thakis@chromium.org

[pedro (no code reviews), 2015-03-05 21:49:59]

Hey Nico, could you please review the changes in
chrome/browser/browser_resources.grd?

[Nico, 2015-03-05 23:49:24]

thakis@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Nico, 2015-03-05 23:49:25]

I can't see any other mdpi, xdpi, xxdpi resources referenced from grd files.
tedchoc, can you verify if this is how android does multi-resolution images in
webui?

[Ted C, 2015-03-06 00:42:32]

On 2015/03/05 23:49:25, Nico wrote:
> I can't see any other mdpi, xdpi, xxdpi resources referenced from grd files.
> tedchoc, can you verify if this is how android does multi-resolution images in
> webui?

Sadly, it's been far too long since I've dealt with webui to answer this with
confidence.

Looking at when we deleted the webui ntp though:
https://codereview.chromium.org/259393006

It doesn't look like we added the images to .grd files but instead used
flattenhtml
to inline it all <maybe?>.

the image set thing does look correct though.

[Nico, 2015-03-09 03:48:44]

Sounds like this is fine then. lgtm.

[pedro (no code reviews), 2015-03-10 23:26:51]

After talking with Ted offline, we've decided to not use PNGs due to its big
size compared to a SVG file.

I've already contacted the designer and he's gonna provide us a SVG version of
the promo image, which we'll use here.

I'm going to update this CL once I have the asset in place.

[Nico, 2015-03-11 13:56:16]

Ok, sounds good too. How large are these images? svg usually doesn't work well
for small (16-32px) icons.

I'm not sure if we have any mechanism like "at small resolutions, use bitmap, on
displays with a higher dpi use an svg" – if not, maybe we should.

But if just an svg works for your use case, that's good.

[Ted C, 2015-03-11 15:16:44]

On 2015/03/11 13:56:16, Nico (traveling) wrote:
> Ok, sounds good too. How large are these images? svg usually doesn't work well
> for small (16-32px) icons.
> 
> I'm not sure if we have any mechanism like "at small resolutions, use bitmap,
on
> displays with a higher dpi use an svg" – if not, maybe we should.
> 
> But if just an svg works for your use case, that's good.

Here's the largest asset from the depending CL mentioned in the description:
https://codereview.chromium.org/978063002/diff/1/chrome/browser/resources/con...

It is a decently large image and it will only be shown once to the user as a
promo.  These types of images are where we should do everything in our means
to reduce binary size (even if it means loosing some fidelity of the original
image).  There is no hard set rule where we should use one format vs the other,
but in Chrome for Android some of our largest images are promo images that only
get shown once, which is silly for all our users to have to pay that download
cost each time.

[Donn Denman, 2015-03-11 16:40:22]

On 2015/03/11 15:16:44, Ted C wrote:
> On 2015/03/11 13:56:16, Nico (traveling) wrote:
> > Ok, sounds good too. How large are these images? svg usually doesn't work
well
> > for small (16-32px) icons.
> > 
> > I'm not sure if we have any mechanism like "at small resolutions, use
bitmap,
> on
> > displays with a higher dpi use an svg" – if not, maybe we should.
> > 
> > But if just an svg works for your use case, that's good.
> 
> Here's the largest asset from the depending CL mentioned in the description:
>
https://codereview.chromium.org/978063002/diff/1/chrome/browser/resources/con...
> 
> It is a decently large image and it will only be shown once to the user as a
> promo.  These types of images are where we should do everything in our means
> to reduce binary size (even if it means loosing some fidelity of the original
> image).  There is no hard set rule where we should use one format vs the
other,
> but in Chrome for Android some of our largest images are promo images that
only
> get shown once, which is silly for all our users to have to pay that download
> cost each time.

Quick correction: the image is part of a promo that the user may see multiple
times if they don't make an immediate choice.  However I fully support Ted's
view that that this image is a part of a transient user flow and not a
consistent part of the UX, so reducing binary size is well worth some image
degradation.

[pedro (no code reviews), 2015-03-24 18:20:26]

Okay, I've got the SVG image from the designer and am updating this issue to
make use of the new asset.

I've also tweaked the alignment of some elements in landscape mode, based on the
offline conversation with the designer.

Please take another look.

[Mathieu, 2015-03-24 18:28:51]

On 2015/03/24 18:20:26, pedrosimonetti wrote:
> Okay, I've got the SVG image from the designer and am updating this issue to
> make use of the new asset.
> 
> I've also tweaked the alignment of some elements in landscape mode, based on
the
> offline conversation with the designer.
> 
> Please take another look.

Sorry haven't been following this closely, is the SVG supposed to be part of
this CL?

[Mathieu, 2015-03-24 18:29:09]

On 2015/03/24 18:28:51, Mathieu Perreault wrote:
> On 2015/03/24 18:20:26, pedrosimonetti wrote:
> > Okay, I've got the SVG image from the designer and am updating this issue to
> > make use of the new asset.
> > 
> > I've also tweaked the alignment of some elements in landscape mode, based on
> the
> > offline conversation with the designer.
> > 
> > Please take another look.
> 
> Sorry haven't been following this closely, is the SVG supposed to be part of
> this CL?

In any case please update the description.

[pedro (no code reviews), 2015-03-24 18:35:35]

On 2015/03/24 18:29:09, Mathieu Perreault wrote:
> On 2015/03/24 18:28:51, Mathieu Perreault wrote:
> > On 2015/03/24 18:20:26, pedrosimonetti wrote:
> > > Okay, I've got the SVG image from the designer and am updating this issue
to
> > > make use of the new asset.
> > > 
> > > I've also tweaked the alignment of some elements in landscape mode, based
on
> > the
> > > offline conversation with the designer.
> > > 
> > > Please take another look.
> > 
> > Sorry haven't been following this closely, is the SVG supposed to be part of
> > this CL?
> 
> In any case please update the description.

Sorry for the confusion Mathieu, the SVG was in a separate branch which I forgot
to squash before uploading the previous patch. CL description has been updated
too.

Please take another look.

[Mathieu, 2015-03-24 18:37:03]

still lgtm!

[Ted C, 2015-03-24 18:48:27]

lgtm

[pedro (no code reviews), 2015-03-24 18:49:28]

Great! Thanks everyone!

[pedro (no code reviews), 2015-03-24 18:49:33]

The CQ bit was checked by pedrosimonetti@chromium.org

[pedro (no code reviews), 2015-03-24 18:49:33]

The patchset sent to the CQ was uploaded after l-g-t-m from donnd@chromium.org,
thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/982643002/#ps60001 (title:
"Actually adding SVG ;)")

[commit-bot: I haz the power, 2015-03-24 18:50:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/982643002/60001

[commit-bot: I haz the power, 2015-03-24 19:25:26]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-03-24 19:26:03]

Patchset 4 (id:??) landed as
https://crrev.com/a4c0df0e847dc9ffc0f3e26a47ac70b53a330513
Cr-Commit-Position: refs/heads/master@{#322045}