Issue 259393006: Remove WebUI NTP on Android.

Issue 259393006: Remove WebUI NTP on Android. (Closed)

Created:
6 years, 7 months ago by aurimas (slooooooooow)

Modified:
6 years, 7 months ago

Reviewers:
Ted C, Nico, Ilya Sherman, kmadhusu

CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, extensions-reviews_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, jar (doing other things), dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, asvitkine+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, estade+watch_chromium.org, chromium-apps-reviews_chromium.org, kmadhusu+watch_chromium.org, Ilya Sherman, Jered, pedrosimonetti+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove WebUI NTP on Android. Relanding https://codereview.chromium.org/256763004/ Original CL got reverted because it landed at the same time as https://codereview.chromium.org/215733002 Chrome for Android has transitioned to using native NTP. This CL removes the WebUI classes and resources. TBR=tedchoc@chromium.org,thakis@chromium.org,isherman@chromium.org BUG=284770 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267346

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -7382 lines)			Patch
M	chrome/app/bookmarks_strings.grdp	View	2 chunks	+0 lines, -14 lines	0 comments	Download
M	chrome/app/generated_resources.grd	View	3 chunks	+10 lines, -88 lines	0 comments	Download
M	chrome/browser/android/new_tab_page_prefs.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_resources.grd	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_service.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/prefs/browser_prefs.cc	View	4 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/resources/ntp_android/OWNERS	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	chrome/browser/resources/ntp_android/bookmarks.css	View	1 chunk	+0 lines, -268 lines	0 comments	Download
D	chrome/browser/resources/ntp_android/bookmarks_tablet.css	View	1 chunk	+0 lines, -18 lines	0 comments	Download
D	chrome/browser/resources/ntp_android/images/bookmark_bg_hdpi.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/images/bookmark_bg_mdpi.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/images/bookmark_bg_tvdpi.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/images/bookmark_bg_xhdpi.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/images/bookmark_border_hdpi.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/images/bookmark_border_mdpi.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/images/bookmark_border_tvdpi.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/images/bookmark_border_xhdpi.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/images/bookmark_folder_hdpi.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/images/bookmark_folder_mdpi.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/images/bookmark_folder_tvdpi.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/images/bookmark_folder_xhdpi.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/images/breadcrumb_hdpi.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/images/breadcrumb_mdpi.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/images/breadcrumb_tvdpi.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/images/breadcrumb_xhdpi.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/images/default_thumbnail.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/images/disclosure_closed_hdpi.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/images/disclosure_closed_mdpi.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/images/disclosure_closed_xhdpi.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/images/disclosure_open_hdpi.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/images/disclosure_open_mdpi.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/images/disclosure_open_xhdpi.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/images/sent_hdpi.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/images/sent_mdpi.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/images/sent_xhdpi.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/images/syncfographic_hdpi.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/images/syncfographic_mdpi.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/images/syncfographic_sw600dp_hdpi.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/images/syncfographic_sw600dp_mdpi.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/images/syncfographic_sw600dp_xhdpi.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/images/syncfographic_xhdpi.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/images/welcome_thumb.png	View	Binary file		0 comments	Download
D	chrome/browser/resources/ntp_android/incognito_tab.css	View	1 chunk	+0 lines, -29 lines	0 comments	Download
D	chrome/browser/resources/ntp_android/mockdata.js	View	1 chunk	+0 lines, -1571 lines	0 comments	Download
D	chrome/browser/resources/ntp_android/mostvisited.css	View	1 chunk	+0 lines, -101 lines	0 comments	Download
D	chrome/browser/resources/ntp_android/mostvisited_tablet.css	View	1 chunk	+0 lines, -171 lines	0 comments	Download
D	chrome/browser/resources/ntp_android/new_tab.html	View	1 chunk	+0 lines, -79 lines	0 comments	Download
D	chrome/browser/resources/ntp_android/ntp_android.css	View	1 chunk	+0 lines, -87 lines	0 comments	Download
D	chrome/browser/resources/ntp_android/ntp_android.js	View	1 chunk	+0 lines, -2736 lines	0 comments	Download
D	chrome/browser/resources/ntp_android/opentabs.css	View	1 chunk	+0 lines, -239 lines	0 comments	Download
D	chrome/browser/resources/ntp_android/opentabs_tablet.css	View	1 chunk	+0 lines, -61 lines	0 comments	Download
M	chrome/browser/search/instant_service.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/search/search_tab_helper.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/metrics_handler.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
D	chrome/browser/ui/webui/ntp/android/OWNERS	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	chrome/browser/ui/webui/ntp/android/bookmarks_handler.h	View	1 chunk	+0 lines, -176 lines	0 comments	Download
D	chrome/browser/ui/webui/ntp/android/bookmarks_handler.cc	View	1 chunk	+0 lines, -583 lines	0 comments	Download
D	chrome/browser/ui/webui/ntp/android/context_menu_handler.h	View	1 chunk	+0 lines, -56 lines	0 comments	Download
D	chrome/browser/ui/webui/ntp/android/context_menu_handler.cc	View	1 chunk	+0 lines, -135 lines	0 comments	Download
D	chrome/browser/ui/webui/ntp/android/navigation_handler.h	View	1 chunk	+0 lines, -68 lines	0 comments	Download
D	chrome/browser/ui/webui/ntp/android/navigation_handler.cc	View	1 chunk	+0 lines, -69 lines	0 comments	Download
D	chrome/browser/ui/webui/ntp/android/new_tab_page_ready_handler.h	View	1 chunk	+0 lines, -38 lines	0 comments	Download
D	chrome/browser/ui/webui/ntp/android/new_tab_page_ready_handler.cc	View	1 chunk	+0 lines, -52 lines	0 comments	Download
D	chrome/browser/ui/webui/ntp/android/ntp_resource_cache_android.cc	View	1 chunk	+0 lines, -170 lines	0 comments	Download
D	chrome/browser/ui/webui/ntp/android/promo_handler.h	View	1 chunk	+0 lines, -84 lines	0 comments	Download
D	chrome/browser/ui/webui/ntp/android/promo_handler.cc	View	1 chunk	+0 lines, -337 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/most_visited_handler.cc	View	3 chunks	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/new_tab_ui.h	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/new_tab_ui.cc	View	5 chunks	+12 lines, -60 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/ntp_login_handler.cc	View	3 chunks	+2 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/ntp_resource_cache.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/recently_closed_tabs_handler.cc	View	4 chunks	+1 line, -23 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	4 chunks	+1 line, -27 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/metrics/histograms/histograms.xml	View	2 chunks	+6 lines, -0 lines	0 comments	Download