util/file/file_reader.h - Issue 982613002: handler: Add report upload

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: util/file/file_reader.h

Issue 982613002: handler: Add report upload (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Address review feedback Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: util/file/file_reader.h

diff --git a/util/file/file_reader.h b/util/file/file_reader.h

index 2d699cb43215aaea1ce5ce4be8ac111e1a067529..0c6856f1a804913ea0835a86956379030ca510c9 100644

--- a/util/file/file_reader.h

+++ b/util/file/file_reader.h

@@ -110,9 +110,7 @@ class FileReader : public FileReaderInterface {

//!

//! \note After a successful call, this method cannot be called again until

//! after Close().

- bool Open(const base::FilePath& path,

- FileWriteMode write_mode,

- FilePermissions permissions);

+ bool Open(const base::FilePath& path);

//! \brief Wraps CheckedCloseHandle().

//!

« no previous file with comments | « handler/mac/main.cc ('k') | util/file/file_reader.cc » ('j') | no next file with comments »