util/file/file_reader.cc - Issue 982613002: handler: Add report upload

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: util/file/file_reader.cc

Issue 982613002: handler: Add report upload (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Address review feedback Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: util/file/file_reader.cc

diff --git a/util/file/file_reader.cc b/util/file/file_reader.cc

index c983f4f6e9ba0b22940f125c7a74c1a898ad2d15..edb3312632f5c57070b9ba76041e06238c3aa382 100644

--- a/util/file/file_reader.cc

+++ b/util/file/file_reader.cc

@@ -69,9 +69,7 @@ FileReader::FileReader()

FileReader::~FileReader() {

}

-bool FileReader::Open(const base::FilePath& path,

- FileWriteMode write_mode,

- FilePermissions permissions) {

+bool FileReader::Open(const base::FilePath& path) {

CHECK(!file_.is_valid());

file_.reset(LoggingOpenFileForRead(path));

if (!file_.is_valid()) {

« no previous file with comments | « util/file/file_reader.h ('k') | no next file » | no next file with comments »