Chromium Code Reviews Chromium Code Reviews
Issue 98253009:
Refactor VM service IDs (Closed)
Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart| Index: runtime/bin/vmservice/client/lib/src/observatory_elements/library_view.html |
| diff --git a/runtime/bin/vmservice/client/lib/src/observatory_elements/library_view.html b/runtime/bin/vmservice/client/lib/src/observatory_elements/library_view.html |
| index 746592b5620c86d33705eaa016a95024df1ee468..6f5df908d11b231957c58eb31c9cb0f9c6214e64 100644 |
| --- a/runtime/bin/vmservice/client/lib/src/observatory_elements/library_view.html |
| +++ b/runtime/bin/vmservice/client/lib/src/observatory_elements/library_view.html |
| @@ -1,7 +1,11 @@ |
| <head> |
| - <link rel="import" href="observatory_element.html"> |
| + <link rel="import" href="class_ref.html"> |
| <link rel="import" href="field_ref.html"> |
| + <link rel="import" href="function_ref.html"> |
| <link rel="import" href="instance_ref.html"> |
| + <link rel="import" href="library_ref.html"> |
| + <link rel="import" href="observatory_element.html"> |
| + <link rel="import" href="script_ref.html"> |
| </head> |
| <polymer-element name="library-view" extends="observatory-element"> |
| <template> |
| @@ -14,7 +18,7 @@ |
| {{ script['kind'] }} |
| </td> |
| <td> |
| - <a href="{{ app.locationManager.currentIsolateScriptLink(script['id'], script['name']) }}">{{ script['name'] }}</a> |
| + <script-ref app="{{ app }}"ref="{{ script }}"></script-ref> |
|
turnidge
2013/12/19 20:39:29
Missing space before 'ref'.
Cutch
2013/12/19 21:53:58
Done.
|
| </td> |
| </tr> |
| </tbody> |
| @@ -24,9 +28,7 @@ |
| <tbody> |
| <tr template repeat="{{ lib in library['libraries'] }}"> |
| <td> |
| - <a href="{{ app.locationManager.currentIsolateObjectLink(lib['id'])}}"> |
| - {{ lib['url'] }} |
| - </a> |
| + <library-ref app="{{ app }}" ref="{{ lib }}"></library-ref> |
| </td> |
| </tr> |
| </tbody> |
| @@ -36,7 +38,7 @@ |
| <tbody> |
| <tr template repeat="{{ variable in library['variables'] }}"> |
| <td><field-ref app="{{ app }}" field="{{ variable }}"></field-ref></td> |
| - <td><instance-ref app="{{ app }}" instance="{{ variable['value'] }}"></instance-ref></td> |
| + <td><instance-ref app="{{ app }}" ref="{{ variable['value'] }}"></instance-ref></td> |
| </tr> |
| </tbody> |
| </table> |
| @@ -45,9 +47,7 @@ |
| <tbody> |
| <tr template repeat="{{ func in library['functions'] }}"> |
| <td> |
| - <a href="{{ app.locationManager.currentIsolateObjectLink(func['id'])}}"> |
| - {{ func['user_name'] }} |
| - </a> |
| + <function-ref app="{{ app }}" ref="{{ func }}"></function-ref> |
| </td> |
| </tr> |
| </tbody> |
| @@ -63,14 +63,10 @@ |
| <tbody> |
| <tr template repeat="{{ cls in library['classes'] }}"> |
| <td> |
| - <a href="{{ app.locationManager.currentIsolateClassLink(cls['id']) }}"> |
| - {{ cls['user_name'] }} |
| - </a> |
| + <class-ref app="{{ app }}" ref="{{ cls }}"></class-ref> |
| </td> |
| <td> |
| - <a href="{{ app.locationManager.currentIsolateClassLink(cls['id']) }}"> |
| - {{ cls['name'] }} |
| - </a> |
| + <class-ref app="{{ app }}" ref="{{ cls }}" internal></class-ref> |
| </td> |
| </tr> |
| </tbody> |
