runtime/bin/vmservice/client/lib/src/observatory_elements/field_ref.html - Issue 98253009: Refactor VM service IDs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/observatory_elements/field_ref.html

Issue 98253009: Refactor VM service IDs (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« runtime/bin/vmservice/client/lib/src/observatory_elements/class_view.html ('K') | « runtime/bin/vmservice/client/lib/src/observatory_elements/code_view.html ('k') | runtime/bin/vmservice/client/lib/src/observatory_elements/field_view.html » ('j') | runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/client/lib/src/observatory_elements/field_ref.html

diff --git a/runtime/bin/vmservice/client/lib/src/observatory_elements/field_ref.html b/runtime/bin/vmservice/client/lib/src/observatory_elements/field_ref.html

index 1d6e71640c56112f8de05dae50a41dc4bfce1f24..88577e318089c531bbc4b993d7bbcc77cf5a97cc 100644

--- a/runtime/bin/vmservice/client/lib/src/observatory_elements/field_ref.html

+++ b/runtime/bin/vmservice/client/lib/src/observatory_elements/field_ref.html

@@ -10,10 +10,10 @@

var

</template>

- <a href="{{ app.locationManager.currentIsolateClassLink(field['declared_type']['id']) }}">

+ <a href="{{ app.locationManager.currentIsolateRelativeLink(field['declared_type']['id']) }}">

{{ field['declared_type']['user_name'] }} </a>

</template>

turnidge 2013/12/19 20:39:29 I think maybe we should make the above a <class-re

Cutch 2013/12/19 21:53:58 I didn't want to mess with field-ref or instance-r

- <a href="{{ app.locationManager.currentIsolateObjectLink(field['id'])}}">

+ <a href="{{ app.locationManager.currentIsolateRelativeLink(field['id'])}}">

{{ field['user_name'] }} </a>

</div>

</template> <script type="application/dart" src="field_ref.dart"></script> </polymer-element>