runtime/bin/vmservice/client/lib/src/observatory_elements/field_ref.html - Issue 98253009: Refactor VM service IDs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/bin/vmservice/client/lib/src/observatory_elements/field_ref.html

Issue 98253009: Refactor VM service IDs (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« runtime/bin/vmservice/client/lib/src/observatory_elements/class_view.html ('K') | « runtime/bin/vmservice/client/lib/src/observatory_elements/code_view.html ('k') | runtime/bin/vmservice/client/lib/src/observatory_elements/field_view.html » ('j') | runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.dart » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <head>	1 <head>

2 <link rel="import" href="observatory_element.html">	2 <link rel="import" href="observatory_element.html">

3 </head>	3 </head>

4 <polymer-element name="field-ref" extends="observatory-element">	4 <polymer-element name="field-ref" extends="observatory-element">

5 <template>	5 <template>

6 <div>	6 <div>

7 <template if="{{ field['final'] }}"> final </template>	7 <template if="{{ field['final'] }}"> final </template>

8 <template if="{{ field['const'] }}"> const </template>	8 <template if="{{ field['const'] }}"> const </template>

9 <template if="{{ (field['declared_type']['name'] == 'dynamic' && !field['final '] && !field['const']) }}">	9 <template if="{{ (field['declared_type']['name'] == 'dynamic' && !field['final '] && !field['const']) }}">

10 var	10 var

11 </template>	11 </template>

12 <template if="{{ (field['declared_type']['name'] != 'dynamic') }}">	12 <template if="{{ (field['declared_type']['name'] != 'dynamic') }}">

13 <a href="{{ app.locationManager.currentIsolateClassLink(field['declared_type'] ['id']) }}">	13 <a href="{{ app.locationManager.currentIsolateRelativeLink(field['declared_typ e']['id']) }}">

14 {{ field['declared_type']['user_name'] }} </a>	14 {{ field['declared_type']['user_name'] }} </a>

15 </template>	15 </template>
	turnidge 2013/12/19 20:39:29 I think maybe we should make the above a <class-re I think maybe we should make the above a <class-ref> Cutch 2013/12/19 21:53:58 I didn't want to mess with field-ref or instance-r Show quoted text On 2013/12/19 20:39:29, turnidge wrote: > I think maybe we should make the above a <class-ref> I didn't want to mess with field-ref or instance-ref
16 <a href="{{ app.locationManager.currentIsolateObjectLink(field['id'])}}">	16 <a href="{{ app.locationManager.currentIsolateRelativeLink(field['id'])}}">

17 {{ field['user_name'] }} </a>	17 {{ field['user_name'] }} </a>

18 </div>	18 </div>

19 </template> <script type="application/dart" src="field_ref.dart"></script> </pol ymer-element>	19 </template> <script type="application/dart" src="field_ref.dart"></script> </pol ymer-element>

OLD	NEW