Refactor VM service IDs

runtime/bin/vmservice/client/lib/src/observatory_elements/class_view.html

Index: runtime/bin/vmservice/client/lib/src/observatory_elements/class_view.html
diff --git a/runtime/bin/vmservice/client/lib/src/observatory_elements/class_view.html b/runtime/bin/vmservice/client/lib/src/observatory_elements/class_view.html
index 762d1a4af22cd521c6ac1cb035987dfb877a0730..0d1f38fc238d03d9d7782f6610ca2dd88497ebe3 100644
--- a/runtime/bin/vmservice/client/lib/src/observatory_elements/class_view.html
+++ b/runtime/bin/vmservice/client/lib/src/observatory_elements/class_view.html
@@ -13,13 +13,9 @@
           class <strong>{{ cls['user_name'] }}</strong>
           <template if="{{ cls['super']['type'] != 'Null' }}">
             extends
-            <a href="{{ app.locationManager.currentIsolateClassLink(cls['super']['id'])}}">
-              {{ cls['super']['user_name'] }}
-            </a>
+            <class-ref app="{{ app }}" ref="{{ cls['super'] }}"></class-ref>
           </template>
-          <a class="pull-right" href="{{ app.locationManager.currentIsolateObjectLink(cls['library']['id'])}}">
-            {{ cls['library']['name'] }}
-          </a>
+          <library-ref app="{{ app }}" ref="{{ cls['library'] }}"></library-ref>

[turnidge, 2013/12/19 20:39:29]

Yes, this is nicer now.  Easier to read.

         </div>
         <div class="panel-body">
           <table class="table table-hover">
@@ -50,7 +46,7 @@
              <tbody>
                 <tr template repeat="{{ field in cls['fields'] }}">
                   <td><field-ref app="{{ app }}" field="{{ field }}"></field-ref></td>
-                  <td><instance-ref app="{{ app }}" instance="{{ field['value'] }}"></instance-ref></td>                  
+                  <td><instance-ref app="{{ app }}" instance="{{ field['value'] }}"></instance-ref></td>

[turnidge, 2013/12/19 20:39:29]

Should this instance= become a ref= here?  Looking at instance-ref, there is no
longer an instance observable.  Seems fishy.

Ditto the field= in the field ref?

[Cutch, 2013/12/19 21:53:58]

Yes but I left that out because I didn't want to disturb your -ref tags.

                 </tr>
               </tbody>
             </table>
@@ -64,8 +60,8 @@
               </thead>
               <tbody>
                 <tr template repeat="{{ function in cls['functions'] }}">
-                  <td><a href="{{ app.locationManager.currentIsolateObjectLink(function['id'])}}">{{ function['user_name'] }}</a></td>
-                  <td><a href="{{ app.locationManager.currentIsolateObjectLink(function['id'])}}">{{ function['name'] }}</a></td>
+                  <td><function-ref app="{{ app }}" ref="{{ function }}"></function-ref></td>
+                  <td><function-ref app="{{ app }}" ref="{{ function }}" internal></function-ref></td>
                 </tr>
               </tbody>
             </table>