Chromium Code Reviews Chromium Code Reviews
Issue 98253009:
Refactor VM service IDs (Closed)
Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart| OLD | NEW |
|---|---|
| 1 <head> | 1 <head> |
| 2 <link rel="import" href="observatory_element.html"> | 2 <link rel="import" href="observatory_element.html"> |
| 3 <link rel="import" href="error_view.html"> | 3 <link rel="import" href="error_view.html"> |
| 4 <link rel="import" href="field_ref.html"> | 4 <link rel="import" href="field_ref.html"> |
| 5 <link rel="import" href="instance_ref.html"> | 5 <link rel="import" href="instance_ref.html"> |
| 6 </head> | 6 </head> |
| 7 <polymer-element name="class-view" extends="observatory-element"> | 7 <polymer-element name="class-view" extends="observatory-element"> |
| 8 <template> | 8 <template> |
| 9 <div class="row"> | 9 <div class="row"> |
| 10 <div class="col-md-8 col-md-offset-2"> | 10 <div class="col-md-8 col-md-offset-2"> |
| 11 <div class="panel panel-warning"> | 11 <div class="panel panel-warning"> |
| 12 <div class="panel-heading"> | 12 <div class="panel-heading"> |
| 13 class <strong>{{ cls['user_name'] }}</strong> | 13 class <strong>{{ cls['user_name'] }}</strong> |
| 14 <template if="{{ cls['super']['type'] != 'Null' }}"> | 14 <template if="{{ cls['super']['type'] != 'Null' }}"> |
| 15 extends | 15 extends |
| 16 <a href="{{ app.locationManager.currentIsolateClassLink(cls['super'] ['id'])}}"> | 16 <class-ref app="{{ app }}" ref="{{ cls['super'] }}"></class-ref> |
| 17 {{ cls['super']['user_name'] }} | |
| 18 </a> | |
| 19 </template> | 17 </template> |
| 20 <a class="pull-right" href="{{ app.locationManager.currentIsolateObjec tLink(cls['library']['id'])}}"> | 18 <library-ref app="{{ app }}" ref="{{ cls['library'] }}"></library-ref> |
|
turnidge
2013/12/19 20:39:29
Yes, this is nicer now. Easier to read.
| |
| 21 {{ cls['library']['name'] }} | |
| 22 </a> | |
| 23 </div> | 19 </div> |
| 24 <div class="panel-body"> | 20 <div class="panel-body"> |
| 25 <table class="table table-hover"> | 21 <table class="table table-hover"> |
| 26 <tbody> | 22 <tbody> |
| 27 <tr> | 23 <tr> |
| 28 <td>Abstract</td><td>{{ cls['abstract'] }}</td> | 24 <td>Abstract</td><td>{{ cls['abstract'] }}</td> |
| 29 </tr> | 25 </tr> |
| 30 <tr> | 26 <tr> |
| 31 <td>Const</td><td>{{ cls['const'] }}</td> | 27 <td>Const</td><td>{{ cls['const'] }}</td> |
| 32 </tr> | 28 </tr> |
| (...skipping 10 matching lines...) Expand all Loading... | |
| 43 <td>VM Name</td><td>{{ cls['name'] }}</td> | 39 <td>VM Name</td><td>{{ cls['name'] }}</td> |
| 44 </tr> | 40 </tr> |
| 45 </tbody> | 41 </tbody> |
| 46 </table> | 42 </table> |
| 47 <template if="{{ cls['error'] == null }}"> | 43 <template if="{{ cls['error'] == null }}"> |
| 48 <blockquote><strong>Fields</strong></blockquote> | 44 <blockquote><strong>Fields</strong></blockquote> |
| 49 <table class="table table-hover"> | 45 <table class="table table-hover"> |
| 50 <tbody> | 46 <tbody> |
| 51 <tr template repeat="{{ field in cls['fields'] }}"> | 47 <tr template repeat="{{ field in cls['fields'] }}"> |
| 52 <td><field-ref app="{{ app }}" field="{{ field }}"></field-ref ></td> | 48 <td><field-ref app="{{ app }}" field="{{ field }}"></field-ref ></td> |
| 53 <td><instance-ref app="{{ app }}" instance="{{ field['value'] }}"></instance-ref></td> | 49 <td><instance-ref app="{{ app }}" instance="{{ field['value'] }}"></instance-ref></td> |
|
turnidge
2013/12/19 20:39:29
Should this instance= become a ref= here? Looking
Cutch
2013/12/19 21:53:58
Yes but I left that out because I didn't want to d
| |
| 54 </tr> | 50 </tr> |
| 55 </tbody> | 51 </tbody> |
| 56 </table> | 52 </table> |
| 57 <blockquote><strong>Functions</strong></blockquote> | 53 <blockquote><strong>Functions</strong></blockquote> |
| 58 <table class="table table-hover"> | 54 <table class="table table-hover"> |
| 59 <thead> | 55 <thead> |
| 60 <tr> | 56 <tr> |
| 61 <th>User Name</th> | 57 <th>User Name</th> |
| 62 <th>VM Name</th> | 58 <th>VM Name</th> |
| 63 </tr> | 59 </tr> |
| 64 </thead> | 60 </thead> |
| 65 <tbody> | 61 <tbody> |
| 66 <tr template repeat="{{ function in cls['functions'] }}"> | 62 <tr template repeat="{{ function in cls['functions'] }}"> |
| 67 <td><a href="{{ app.locationManager.currentIsolateObjectLink(f unction['id'])}}">{{ function['user_name'] }}</a></td> | 63 <td><function-ref app="{{ app }}" ref="{{ function }}"></funct ion-ref></td> |
| 68 <td><a href="{{ app.locationManager.currentIsolateObjectLink(f unction['id'])}}">{{ function['name'] }}</a></td> | 64 <td><function-ref app="{{ app }}" ref="{{ function }}" interna l></function-ref></td> |
| 69 </tr> | 65 </tr> |
| 70 </tbody> | 66 </tbody> |
| 71 </table> | 67 </table> |
| 72 </template> | 68 </template> |
| 73 <template if="{{ cls['error'] != null }}"> | 69 <template if="{{ cls['error'] != null }}"> |
| 74 <error-view error_obj="{{ cls['error'] }}"></error-view> | 70 <error-view error_obj="{{ cls['error'] }}"></error-view> |
| 75 </template> | 71 </template> |
| 76 </div> | 72 </div> |
| 77 </div> | 73 </div> |
| 78 </div> | 74 </div> |
| 79 </div> | 75 </div> |
| 80 </template> | 76 </template> |
| 81 <script type="application/dart" src="class_view.dart"></script> | 77 <script type="application/dart" src="class_view.dart"></script> |
| 82 </polymer-element> | 78 </polymer-element> |
| OLD | NEW |
