remoting/client/plugin/delegating_signal_strategy.cc - Issue 982413002: base: Stop passing a non-const ref to ObserverListBase::Iterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/client/plugin/delegating_signal_strategy.cc

Issue 982413002: base: Stop passing a non-const ref to ObserverListBase::Iterator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: observerref: fixwindowsbuild Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/client/plugin/delegating_signal_strategy.cc

diff --git a/remoting/client/plugin/delegating_signal_strategy.cc b/remoting/client/plugin/delegating_signal_strategy.cc

index f8d02fd2b9a5f7c4e5f4f20ff39b676dd596b60b..9caf1ffba8db3aff9adf8886e6d351422c62c641 100644

--- a/remoting/client/plugin/delegating_signal_strategy.cc

+++ b/remoting/client/plugin/delegating_signal_strategy.cc

@@ -27,7 +27,7 @@ void DelegatingSignalStrategy::OnIncomingMessage(const std::string& message) {

return;

}

- ObserverListBase<Listener>::Iterator it(listeners_);

+ ObserverListBase<Listener>::Iterator it(&listeners_);

Listener* listener;

while ((listener = it.GetNext()) != nullptr) {

if (listener->OnSignalStrategyIncomingStanza(stanza.get()))

« no previous file with comments | « ppapi/proxy/ppapi_proxy_test.cc ('k') | remoting/host/register_support_host_request_unittest.cc » ('j') | no next file with comments »