ppapi/proxy/ppapi_proxy_test.cc - Issue 982413002: base: Stop passing a non-const ref to ObserverListBase::Iterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/proxy/ppapi_proxy_test.cc

Issue 982413002: base: Stop passing a non-const ref to ObserverListBase::Iterator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: observerref: fixwindowsbuild Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ppapi/proxy/ppapi_proxy_test.cc

diff --git a/ppapi/proxy/ppapi_proxy_test.cc b/ppapi/proxy/ppapi_proxy_test.cc

index 5a7867d5e18b1d6e9686cfabae28c38773f3693a..14362d964afca40a9e03516f075fc274edbad5bd 100644

--- a/ppapi/proxy/ppapi_proxy_test.cc

+++ b/ppapi/proxy/ppapi_proxy_test.cc

@@ -65,8 +65,7 @@ PPB_Proxy_Private ppb_proxy_private = {

ObserverList<ProxyTestHarnessBase> get_interface_handlers_;

const void* MockGetInterface(const char* name) {

- ObserverList<ProxyTestHarnessBase>::Iterator it =

- get_interface_handlers_;

+ ObserverList<ProxyTestHarnessBase>::Iterator it(&get_interface_handlers_);

while (ProxyTestHarnessBase* observer = it.GetNext()) {

const void* interface = observer->GetInterface(name);

if (interface)

« no previous file with comments | « net/base/net_log.cc ('k') | remoting/client/plugin/delegating_signal_strategy.cc » ('j') | no next file with comments »