net/base/net_log.cc - Issue 982413002: base: Stop passing a non-const ref to ObserverListBase::Iterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/net_log.cc

Issue 982413002: base: Stop passing a non-const ref to ObserverListBase::Iterator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: observerref: fixwindowsbuild Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/base/net_log.cc

diff --git a/net/base/net_log.cc b/net/base/net_log.cc

index 4f4603563992244d2336e86fddb18055316cb09b..86f06ed154ad3bb1b957b05fb2c02b7548dc2846 100644

--- a/net/base/net_log.cc

+++ b/net/base/net_log.cc

@@ -276,7 +276,7 @@ void NetLog::UpdateLogLevel() {

// Look through all the observers and find the finest granularity

// log level (higher values of the enum imply *lower* log levels).

LogLevel new_effective_log_level = LOG_NONE;

- ObserverListBase<ThreadSafeObserver>::Iterator it(observers_);

+ ObserverListBase<ThreadSafeObserver>::Iterator it(&observers_);

ThreadSafeObserver* observer;

while ((observer = it.GetNext()) != NULL) {

new_effective_log_level =

« no previous file with comments | « ipc/ipc_test_sink.cc ('k') | ppapi/proxy/ppapi_proxy_test.cc » ('j') | no next file with comments »