Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 982363003: Add -fsanitize=cfi-vptr to list of flags disabled in AVX2 code. (Closed)

Created:
5 years, 9 months ago by pcc1
Modified:
5 years, 9 months ago
Reviewers:
Johann, Nico
CC:
wwcv, jzern, fgalligan1, Tom Finegan
Base URL:
https://chromium.googlesource.com/chromium/deps/libvpx.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add -fsanitize=cfi-vptr to list of flags disabled in AVX2 code. This feature implies -flto so we need to disable it for the same reasons we currently need to disable -flto. BUG=464797 R=thakis@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/libvpx/+/45ff892413df2765683780b6d9e7146b08234054

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M generate_gypi.sh View 1 chunk +1 line, -1 line 0 comments Download
M libvpx_srcs_x86_64_intrinsics.gypi View 1 chunk +1 line, -1 line 0 comments Download
M libvpx_srcs_x86_intrinsics.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
pcc1
5 years, 9 months ago (2015-03-06 20:00:53 UTC) #1
Nico
lgtm
5 years, 9 months ago (2015-03-06 21:12:10 UTC) #2
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 9 months ago (2015-03-06 21:17:29 UTC) #5
pcc
On 2015/03/06 21:17:29, I haz the power (commit-bot) wrote: > Commit queue rejected this change ...
5 years, 9 months ago (2015-03-06 21:22:27 UTC) #6
Johann
On 2015/03/06 21:22:27, pcc wrote: > On 2015/03/06 21:17:29, I haz the power (commit-bot) wrote: ...
5 years, 9 months ago (2015-03-06 22:10:48 UTC) #7
pcc1
On 2015/03/06 22:10:48, Johann wrote: > On 2015/03/06 21:22:27, pcc wrote: > > On 2015/03/06 ...
5 years, 9 months ago (2015-03-06 22:16:56 UTC) #8
Johann
On 2015/03/06 22:16:56, pcc1 wrote: > I guess this might be because I am not ...
5 years, 9 months ago (2015-03-07 00:06:48 UTC) #9
Johann
5 years, 9 months ago (2015-03-09 20:03:33 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
45ff892413df2765683780b6d9e7146b08234054 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698