Clear Search results in the Mac app launcher on close, rather than launch.

Clear Search results in the Mac app launcher on close, rather than launch.

The Mac app launcher now fades away when it is dismissed, so the
animation that resets the search state can be seen while it's fading
out. To match Win/CrOS, this CL moves the clear to when the window is
closed; at the end of the animation.

Adds a unit test: AppListWindowControllerTest.CloseClearsSearch to
cover.

BUG=321541
TEST=Launch something from a search in the Mac App Launcher. While it's
fading out you shouldn't see the apps grid slide back in.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238323

[tapted, 2013-12-02 05:48:32]

Hi kozooo, please take a look. (note: I didn't really want to expose
showingSearchResults_.. but animations make more `heuristic` ways flaky. Not so
bad I guess since it's in Objective C's equivalent of `TestingAPI`).

[koz (OOO until 15th September), 2013-12-02 22:49:45]

lgtm

https://codereview.chromium.org/98233002/diff/1/ui/app_list/cocoa/app_list_wi...
File ui/app_list/cocoa/app_list_window_controller_unittest.mm (right):

https://codereview.chromium.org/98233002/diff/1/ui/app_list/cocoa/app_list_wi...
ui/app_list/cocoa/app_list_window_controller_unittest.mm:74: // Test that search
results are cleared when the window closes, and not before.
Maybe elaborate here like "Test that search results are cleared when the window
closes, not when a search result is selected. Clearing the search when a search
result is selected means that we will see the search results slide away while
the window closes, which looks weird."

[tapted, 2013-12-03 01:45:26]

https://codereview.chromium.org/98233002/diff/1/ui/app_list/cocoa/app_list_wi...
File ui/app_list/cocoa/app_list_window_controller_unittest.mm (right):

https://codereview.chromium.org/98233002/diff/1/ui/app_list/cocoa/app_list_wi...
ui/app_list/cocoa/app_list_window_controller_unittest.mm:74: // Test that search
results are cleared when the window closes, and not before.
On 2013/12/02 22:49:45, koz wrote:
> Maybe elaborate here like "Test that search results are cleared when the
window
> closes, not when a search result is selected. Clearing the search when a
search
> result is selected means that we will see the search results slide away while
> the window closes, which looks weird."

Done.

[commit-bot: I haz the power, 2013-12-03 01:46:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tapted@chromium.org/98233002/20001

[commit-bot: I haz the power, 2013-12-03 04:17:58]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-12-03 05:04:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tapted@chromium.org/98233002/20001

[commit-bot: I haz the power, 2013-12-03 08:03:53]

Change committed as 238323