Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: ui/app_list/cocoa/app_list_window_controller_unittest.mm

Issue 98233002: Clear Search results in the Mac app launcher on close, rather than launch. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Elborate on comment. And a rebase if I'm unlucky Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/app_list/cocoa/app_list_window_controller.mm ('k') | ui/app_list/test/app_list_test_view_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/app_list/cocoa/app_list_window_controller_unittest.mm
diff --git a/ui/app_list/cocoa/app_list_window_controller_unittest.mm b/ui/app_list/cocoa/app_list_window_controller_unittest.mm
index 68b273d71a28410a9e3a23f8499fb66d23a254e0..0f766917750b4b1df3da68280d09d6d1f4c1da15 100644
--- a/ui/app_list/cocoa/app_list_window_controller_unittest.mm
+++ b/ui/app_list/cocoa/app_list_window_controller_unittest.mm
@@ -3,10 +3,12 @@
// found in the LICENSE file.
#import "base/mac/scoped_nsobject.h"
+#include "base/strings/utf_string_conversions.h"
#import "testing/gtest_mac.h"
#include "ui/app_list/app_list_view_delegate.h"
#import "ui/app_list/cocoa/app_list_view_controller.h"
#import "ui/app_list/cocoa/app_list_window_controller.h"
+#include "ui/app_list/search_box_model.h"
#include "ui/app_list/test/app_list_test_view_delegate.h"
#import "ui/base/test/ui_cocoa_test_helper.h"
@@ -68,3 +70,26 @@ TEST_F(AppListWindowControllerTest, DismissWithEscape) {
[[controller_ window] cancelOperation:controller_];
EXPECT_EQ(1, delegate()->dismiss_count());
}
+
+// Test that search results are cleared when the window closes, not when a
+// search result is selected. If cleared upon selection, the animation showing
+// the results sliding away is seen as the window closes, which looks weird.
+TEST_F(AppListWindowControllerTest, CloseClearsSearch) {
+ [[controller_ window] makeKeyAndOrderFront:nil];
+ app_list::SearchBoxModel* model = delegate()->GetModel()->search_box();
+ AppListViewController* view_controller = [controller_ appListViewController];
+
+ EXPECT_FALSE([view_controller showingSearchResults]);
+
+ const base::string16 search_text(ASCIIToUTF16("test"));
+ model->SetText(search_text);
+ EXPECT_TRUE([view_controller showingSearchResults]);
+
+ EXPECT_EQ(0, delegate()->open_search_result_count());
+ [view_controller openResult:nil];
+ EXPECT_EQ(1, delegate()->open_search_result_count());
+
+ EXPECT_TRUE([view_controller showingSearchResults]);
+ [[controller_ window] close]; // Hide.
+ EXPECT_FALSE([view_controller showingSearchResults]);
+}
« no previous file with comments | « ui/app_list/cocoa/app_list_window_controller.mm ('k') | ui/app_list/test/app_list_test_view_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698