Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1476)

Unified Diff: tools/dm_flags.py

Issue 982163002: When running under Valgrind, don't draw .webps into .pdfs. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dm_flags.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dm_flags.py
diff --git a/tools/dm_flags.py b/tools/dm_flags.py
index 583d4f2b479f96508d459b7fb63a5104194245e7..bf194d164b2cf7bcc0b8823f388fde4e5ccc0c71 100755
--- a/tools/dm_flags.py
+++ b/tools/dm_flags.py
@@ -32,8 +32,7 @@ def get_args(bot):
else:
configs.extend(['msaa16', 'nvprmsaa16'])
# Runs out of memory on Android bots and Daisy. Everyone else seems fine.
- # Valgrind: PDF + .webp -> jumps depending on uninitialized memory. skia:3505
- if 'Android' not in bot and 'Daisy' not in bot and 'Valgrind' not in bot:
+ if 'Android' not in bot and 'Daisy' not in bot:
configs.append('pdf')
# Xoom and NP are running out of RAM when we run all these modes. skia:3255
@@ -59,6 +58,10 @@ def get_args(bot):
blacklist.extend('gpu skp _ gpu image _ gpu subset _'.split(' '))
blacklist.extend('msaa skp _ msaa image _ gpu subset _'.split(' '))
+ # PDF + .webp -> jumps depending on uninitialized memory. skia:3505
+ if 'Valgrind' in bot:
+ blacklist.extend('pdf _ .webp'.split(' '))
+
if blacklist:
args.append('--blacklist')
args.extend(blacklist)
« no previous file with comments | « tools/dm_flags.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698