Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: tools/dm_flags.py

Issue 982163002: When running under Valgrind, don't draw .webps into .pdfs. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/dm_flags.json ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 2
3 usage = ''' 3 usage = '''
4 Write extra flags to outfile for DM based on the bot name: 4 Write extra flags to outfile for DM based on the bot name:
5 $ python dm_flags.py outfile Test-Mac10.9-MacMini6.2-HD4000-x86_64-Release 5 $ python dm_flags.py outfile Test-Mac10.9-MacMini6.2-HD4000-x86_64-Release
6 Or run self-tests: 6 Or run self-tests:
7 $ python dm_flags.py test 7 $ python dm_flags.py test
8 ''' 8 '''
9 9
10 import inspect 10 import inspect
(...skipping 14 matching lines...) Expand all
25 configs = ['565', '8888', 'gpu'] 25 configs = ['565', '8888', 'gpu']
26 # The S4 crashes and the NP produces a long error stream when we run with 26 # The S4 crashes and the NP produces a long error stream when we run with
27 # MSAA. 27 # MSAA.
28 if ('GalaxyS4' not in bot and 28 if ('GalaxyS4' not in bot and
29 'NexusPlayer' not in bot): 29 'NexusPlayer' not in bot):
30 if 'Android' in bot: 30 if 'Android' in bot:
31 configs.extend(['msaa4', 'nvprmsaa4']) 31 configs.extend(['msaa4', 'nvprmsaa4'])
32 else: 32 else:
33 configs.extend(['msaa16', 'nvprmsaa16']) 33 configs.extend(['msaa16', 'nvprmsaa16'])
34 # Runs out of memory on Android bots and Daisy. Everyone else seems fine. 34 # Runs out of memory on Android bots and Daisy. Everyone else seems fine.
35 # Valgrind: PDF + .webp -> jumps depending on uninitialized memory. skia:3505 35 if 'Android' not in bot and 'Daisy' not in bot:
36 if 'Android' not in bot and 'Daisy' not in bot and 'Valgrind' not in bot:
37 configs.append('pdf') 36 configs.append('pdf')
38 37
39 # Xoom and NP are running out of RAM when we run all these modes. skia:3255 38 # Xoom and NP are running out of RAM when we run all these modes. skia:3255
40 if ('Xoom' not in bot and 39 if ('Xoom' not in bot and
41 'NexusPlayer' not in bot): 40 'NexusPlayer' not in bot):
42 configs.extend(mode + '-8888' for mode in 41 configs.extend(mode + '-8888' for mode in
43 ['serialize', 'tiles_rt', 'pipe']) 42 ['serialize', 'tiles_rt', 'pipe'])
44 configs.append('tiles_rt-gpu') 43 configs.append('tiles_rt-gpu')
45 if 'ANGLE' in bot: 44 if 'ANGLE' in bot:
46 configs.append('angle') 45 configs.append('angle')
47 args.append('--config') 46 args.append('--config')
48 args.extend(configs) 47 args.extend(configs)
49 48
50 blacklist = [] 49 blacklist = []
51 # This image is too large to be a texture for many GPUs. 50 # This image is too large to be a texture for many GPUs.
52 blacklist.extend('gpu _ PANO_20121023_214540.jpg'.split(' ')) 51 blacklist.extend('gpu _ PANO_20121023_214540.jpg'.split(' '))
53 blacklist.extend('msaa _ PANO_20121023_214540.jpg'.split(' ')) 52 blacklist.extend('msaa _ PANO_20121023_214540.jpg'.split(' '))
54 53
55 # Drawing SKPs or images into GPU canvases is a New Thing. 54 # Drawing SKPs or images into GPU canvases is a New Thing.
56 # It seems like we're running out of RAM on some Android bots, so start off 55 # It seems like we're running out of RAM on some Android bots, so start off
57 # with a very wide blacklist disabling all these tests on all Android bots. 56 # with a very wide blacklist disabling all these tests on all Android bots.
58 if 'Android' in bot: # skia:3255 57 if 'Android' in bot: # skia:3255
59 blacklist.extend('gpu skp _ gpu image _ gpu subset _'.split(' ')) 58 blacklist.extend('gpu skp _ gpu image _ gpu subset _'.split(' '))
60 blacklist.extend('msaa skp _ msaa image _ gpu subset _'.split(' ')) 59 blacklist.extend('msaa skp _ msaa image _ gpu subset _'.split(' '))
61 60
61 # PDF + .webp -> jumps depending on uninitialized memory. skia:3505
62 if 'Valgrind' in bot:
63 blacklist.extend('pdf _ .webp'.split(' '))
64
62 if blacklist: 65 if blacklist:
63 args.append('--blacklist') 66 args.append('--blacklist')
64 args.extend(blacklist) 67 args.extend(blacklist)
65 68
66 match = [] 69 match = []
67 if 'Alex' in bot: # skia:2793 70 if 'Alex' in bot: # skia:2793
68 # This machine looks to be running out of heap. 71 # This machine looks to be running out of heap.
69 # Running with fewer threads may help. 72 # Running with fewer threads may help.
70 args.extend(['--threads', '1']) 73 args.extend(['--threads', '1'])
71 if 'Valgrind' in bot: # skia:3021 74 if 'Valgrind' in bot: # skia:3021
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 if len(sys.argv) == 2 and sys.argv[1] == 'test': 129 if len(sys.argv) == 2 and sys.argv[1] == 'test':
127 self_test() 130 self_test()
128 sys.exit(0) 131 sys.exit(0)
129 132
130 if len(sys.argv) != 3: 133 if len(sys.argv) != 3:
131 print usage 134 print usage
132 sys.exit(1) 135 sys.exit(1)
133 136
134 with open(sys.argv[1], 'w') as out: 137 with open(sys.argv[1], 'w') as out:
135 json.dump(get_args(sys.argv[2]), out) 138 json.dump(get_args(sys.argv[2]), out)
OLDNEW
« no previous file with comments | « tools/dm_flags.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698