Issue 982163002: When running under Valgrind, don't draw .webps into .pdfs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 982163002: When running under Valgrind, don't draw .webps into .pdfs. (Closed)

Created:
5 years, 9 months ago by mtklein_C

Modified:
5 years, 9 months ago

Reviewers:
scroggo, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

When running under Valgrind, don't draw .webps into .pdfs. This blacklist entry bans any test with 'pdf' config, any source type, whose name has '.webp' in it. In practice, that's 'image' or 'subset' source type decoding some WEBP file. BUG=skia:3505 Committed: https://skia.googlesource.com/skia/+/150d3503ede63564be83b9b083d2d3dd08462475

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	tools/dm_flags.json	View		2 chunks	+4 lines, -0 lines	0 comments	Download
	M	tools/dm_flags.py	View		2 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/982163002/1

5 years, 9 months ago (2015-03-05 21:32:54 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-05 21:38:21 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/150d3503ede63564be83b9b083d2d3dd08462475

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages