Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 982123003: convert more things to maybe (Closed)

Created:
5 years, 9 months ago by dcarney
Modified:
5 years, 8 months ago
Reviewers:
Sven Panne, adamk
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

convert more things to maybe BUG=v8:3929 LOG=y Committed: https://crrev.com/b9bf2051cd9c62de75fdd0300d2801c6328a80cc Cr-Commit-Position: refs/heads/master@{#27038}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -186 lines) Patch
M include/v8.h View 1 7 chunks +17 lines, -0 lines 1 comment Download
M src/api.cc View 1 2 3 4 5 19 chunks +158 lines, -186 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Sven Panne
lgtm
5 years, 9 months ago (2015-03-06 10:21:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/982123003/90001
5 years, 9 months ago (2015-03-06 10:26:46 UTC) #4
commit-bot: I haz the power
Committed patchset #6 (id:90001)
5 years, 9 months ago (2015-03-06 10:28:06 UTC) #5
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/b9bf2051cd9c62de75fdd0300d2801c6328a80cc Cr-Commit-Position: refs/heads/master@{#27038}
5 years, 9 months ago (2015-03-06 10:28:25 UTC) #6
adamk
5 years, 8 months ago (2015-04-06 22:21:03 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/982123003/diff/90001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/982123003/diff/90001/include/v8.h#newcode1090
include/v8.h:1090: MaybeLocal<Value> Run(Local<Context> context);
What is the |context| argument here? Why isn't the currently-entered Context in
this isolate sufficient? I ran into this today and was a bit surprised. If
nothing else it seems like there should be something in the comment explaining
the argument. I'm asking because I intend to add some similar classes/methods
around Modules.

Same question goes for all the places below where Context got added.

Powered by Google App Engine
This is Rietveld 408576698