convert more things to maybe

include/v8.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** \mainpage V8 API Reference Guide
  *
  * V8 is Google's open source JavaScript engine.
  *
  * This set of documents provides reference material generated from the
  * V8 header file, include/v8.h.
@@ skipping 1067 matching lines @@
 
   // TODO(dcarney): deprecate.
   static Local<Script> Compile(Handle<String> source,
                                Handle<String> file_name);
 
   /**
    * Runs the script returning the resulting value. It will be run in the
    * context in which it was created (ScriptCompiler::CompileBound or
    * UnboundScript::BindToCurrentContext()).
    */
+  // TODO(dcarney): deprecate
   Local<Value> Run();
+  MaybeLocal<Value> Run(Local<Context> context);

[adamk, 2015/04/06 22:21:02]

What is the |context| argument here? Why isn't the currently-entered Context in
this isolate sufficient? I ran into this today and was a bit surprised. If
nothing else it seems like there should be something in the comment explaining
the argument. I'm asking because I intend to add some similar classes/methods
around Modules.

Same question goes for all the places below where Context got added.

 
   /**
    * Returns the corresponding context-unbound script.
    */
   Local<UnboundScript> GetUnboundScript();
 
   V8_DEPRECATED("Use GetUnboundScript()->GetId()",
                 int GetId()) {
     return GetUnboundScript()->GetId();
   }
@@ skipping 292 matching lines @@
       Isolate* isolate, Source* source, CompileOptions options, bool is_module);
 };
 
 
 /**
  * An error message.
  */
 class V8_EXPORT Message {
  public:
   Local<String> Get() const;
+
+  // TODO(dcarney): deprecate
   Local<String> GetSourceLine() const;
+  MaybeLocal<String> GetSourceLine(Local<Context> context) const;
 
   /**
    * Returns the origin for the script from where the function causing the
    * error originates.
    */
   ScriptOrigin GetScriptOrigin() const;
 
   /**
    * Returns the resource name for the script from where the function causing
    * the error originates.
    */
   Handle<Value> GetScriptResourceName() const;
 
   /**
    * Exception stack trace. By default stack traces are not captured for
    * uncaught exceptions. SetCaptureStackTraceForUncaughtExceptions allows
    * to change this option.
    */
   Handle<StackTrace> GetStackTrace() const;
 
   /**
    * Returns the number, 1-based, of the line where the error occurred.
    */
+  // TODO(dcarney): deprecate
   int GetLineNumber() const;
+  Maybe<int> GetLineNumber(Local<Context> context) const;
 
   /**
    * Returns the index within the script of the first character where
    * the error occurred.
    */
   int GetStartPosition() const;
 
   /**
    * Returns the index within the script of the last character where
    * the error occurred.
    */
   int GetEndPosition() const;
 
   /**
    * Returns the index within the line of the first character where
    * the error occurred.
    */
+  // TODO(dcarney): deprecate
   int GetStartColumn() const;
+  Maybe<int> GetStartColumn(Local<Context> context) const;
 
   /**
    * Returns the index within the line of the last character where
    * the error occurred.
    */
+  // TODO(dcarney): deprecate
   int GetEndColumn() const;
+  Maybe<int> GetEndColumn(Local<Context> context) const;
 
   /**
    * Passes on the value set by the embedder when it fed the script from which
    * this Message was generated to V8.
    */
   bool IsSharedCrossOrigin() const;
 
   // TODO(1245381): Print to a string instead of on a FILE.
   static void PrintCurrentStackTrace(Isolate* isolate, FILE* out);
 
@@ skipping 146 matching lines @@
  */
 class V8_EXPORT JSON {
  public:
   /**
    * Tries to parse the string |json_string| and returns it as value if
    * successful.
    *
    * \param json_string The string to parse.
    * \return The corresponding value if successfully parsed.
    */
+  // TODO(dcarney): deprecate
   static Local<Value> Parse(Local<String> json_string);
+  static MaybeLocal<Value> Parse(Isolate* isolate, Local<String> json_string);
 };
 
 
 /**
  * A map whose keys are referenced weakly. It is similar to JavaScript WeakMap
  * but can be created without entering a v8::Context and hence shouldn't
  * escape to JavaScript.
  */
 class V8_EXPORT NativeWeakMap : public Data {
  public:
@@ skipping 292 matching lines @@
   inline Local<String> ToDetailString() const;
   inline Local<Object> ToObject() const;
   inline Local<Integer> ToInteger() const;
   inline Local<Uint32> ToUint32() const;
   inline Local<Int32> ToInt32() const;
 
   /**
    * Attempts to convert a string to an array index.
    * Returns an empty handle if the conversion fails.
    */
+  // TODO(dcarney): deprecate.
   Local<Uint32> ToArrayIndex() const;
+  MaybeLocal<Uint32> ToArrayIndex(Local<Context> context) const;
 
   Maybe<bool> BooleanValue(Local<Context> context) const;
   Maybe<double> NumberValue(Local<Context> context) const;
   Maybe<int64_t> IntegerValue(Local<Context> context) const;
   Maybe<uint32_t> Uint32Value(Local<Context> context) const;
   Maybe<int32_t> Int32Value(Local<Context> context) const;
 
   // TODO(dcarney): deprecate all these.
   bool BooleanValue() const;
   double NumberValue() const;
   int64_t IntegerValue() const;
   uint32_t Uint32Value() const;
   int32_t Int32Value() const;
 
   /** JS == */
+  // TODO(dcarney): deprecate.
   bool Equals(Handle<Value> that) const;
+  Maybe<bool> Equals(Local<Context> context, Handle<Value> that) const;
   bool StrictEquals(Handle<Value> that) const;
   bool SameValue(Handle<Value> that) const;
 
   template <class T> V8_INLINE static Value* Cast(T* value);
 
  private:
   V8_INLINE bool QuickIsUndefined() const;
   V8_INLINE bool QuickIsNull() const;
   V8_INLINE bool QuickIsString() const;
   bool FullIsUndefined() const;
@@ skipping 5797 matching lines @@
  */
 
 
 }  // namespace v8
 
 
 #undef TYPE_CHECK
 
 
 #endif  // V8_H_