Issue 982093003: Add a new analyze command to shelldb to run the dart analyzer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 982093003: Add a new analyze command to shelldb to run the dart analyzer (Closed)

Created:
5 years, 9 months ago by eseidel

Modified:
5 years, 9 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add a new analyze command to shelldb to run the dart analyzer This just makes it easier to run with the correct flags. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ac5d711c4c6e52e0e259bd20cba326a04de69d35

Patch Set 1 #

Total comments: 1

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -2 lines)			Patch
	M	sky/tools/shelldb	View		3 chunks	+32 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

lgtm https://codereview.chromium.org/982093003/diff/1/sky/tools/shelldb File sky/tools/shelldb (right): https://codereview.chromium.org/982093003/diff/1/sky/tools/shelldb#newcode218 sky/tools/shelldb:218: print " ".join(analyzer_args) Remove?

5 years, 9 months ago (2015-03-05 19:28:06 UTC) #1

eseidel

5 years, 9 months ago (2015-03-05 19:29:01 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ac5d711c4c6e52e0e259bd20cba326a04de69d35 (presubmit successful).

Expand Messages | Collapse Messages