Add a new analyze command to shelldb to run the dart analyzer

sky/tools/shelldb

 #!/usr/bin/env python
 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from skypy.skyserver import SkyServer
 import argparse
 import json
 import logging
 import os
@@ skipping 125 matching lines @@
         apk_path = os.path.join(args.build_dir, 'apks', APK_NAME)
         if not os.path.exists(apk_path):
             print "'%s' does not exist?" % apk_path
             return 2
 
         sky_server = self._sky_server_for_args(args)
         pids['sky_server_pid'] = sky_server.start()
         pids['sky_server_port'] = sky_server.port
         pids['sky_server_root'] = sky_server.root
 
-        pids['build_dir'] = args.build_dir
+        pids['build_dir'] = os.path.abspath(args.build_dir)
 
         subprocess.check_call([ADB_PATH, 'install', '-r', apk_path])
 
         port_string = 'tcp:%s' % sky_server.port
         subprocess.check_call([
             ADB_PATH, 'reverse', port_string, port_string
         ])
         pids['remote_sky_server_port'] = sky_server.port
 
         subprocess.check_call([ADB_PATH, 'shell',
@@ skipping 25 matching lines @@
         if 'remote_sky_server_port' in self.pids:
             port_string = 'tcp:%s' % self.pids['remote_sky_server_port']
             subprocess.call([ADB_PATH, 'reverse', '--remove', port_string])
 
         subprocess.call([
             ADB_PATH, 'shell', 'am', 'force-stop', ANDROID_PACKAGE])
 
         pids.clear()
 
 
+class Analyze(object):
+    def add_subparser(self, subparsers):
+        analyze_parser = subparsers.add_parser('analyze',
+            help=('run the dart analyzer with sky url mappings'))
+        analyze_parser.add_argument('app_path', type=str)
+        analyze_parser.set_defaults(func=self.run)
+
+    def run(self, args, pids):
+        ANALYZER_PATH = 'third_party/dart-sdk/dart-sdk/bin/dartanalyzer'
+
+        build_dir = os.path.abspath(pids['build_dir'])
+        bindings_path = os.path.join(build_dir, 'gen/sky/bindings')
+        sky_builtin_path = \
+            os.path.join(SRC_ROOT, 'sky/engine/bindings/builtin.dart')
+        sky_core_path = os.path.join(bindings_path, 'sky_core.dart')
+        mojo_bindings_path = \
+            os.path.join(SRC_ROOT, 'mojo/public/dart/bindings.dart')
+        mojo_core_path = os.path.join(SRC_ROOT, 'mojo/public/dart/core.dart')
+        analyzer_args = [ANALYZER_PATH,
+            # sky_core.dart does not compile cleanly yet. :(
+            # "--url-mapping=dart:sky,%s" % sky_core_path,
+            "--url-mapping=dart:sky_builtin,%s" % sky_builtin_path,
+            "--url-mapping=mojo:bindings,%s" % mojo_bindings_path,
+            "--url-mapping=mojo:core,%s" % mojo_core_path,
+            args.app_path
+        ]
+        print " ".join(analyzer_args)

[abarth-chromium, 2015/03/05 19:28:06]

Remove?

+        subprocess.call(analyzer_args)
+
+
 class SkyShellRunner(object):
     def main(self):
         logging.basicConfig(level=logging.WARNING)
 
         parser = argparse.ArgumentParser(description='Sky Shell Runner')
         subparsers = parser.add_subparsers(help='sub-command help')
 
-        for command in [StartSky(), StopSky()]:
+        for command in [StartSky(), StopSky(), Analyze()]:
             command.add_subparser(subparsers)
 
         args = parser.parse_args()
         pids = Pids.read_from(PID_FILE_PATH, PID_FILE_KEYS)
         exit_code = args.func(args, pids)
         # We could do this with an at-exit handler instead?
         pids.write_to(PID_FILE_PATH)
         sys.exit(exit_code)
 
 
 if __name__ == '__main__':
     SkyShellRunner().main()