Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 981773003: Remove the flag to disable new hotwording. (Closed)

Created:
5 years, 9 months ago by Anand Mistry (off Chromium)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, rlp+watch_chromium.org, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the flag to disable new hotwording. Removing all the dead code as a result of this is large change and will be done separately. BUG=439143 Committed: https://crrev.com/5ded0c90a0d0b68a5b467cc9abcf3a0396d45b9c Cr-Commit-Position: refs/heads/master@{#320843}

Patch Set 1 #

Patch Set 2 : Fix build. #

Patch Set 3 : Rebase. #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -33 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/extensions/hotword_browsertest.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/search/hotword_service.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/search/hotword_service.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/search/hotword_service_unittest.cc View 1 2 3 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
Anand Mistry (off Chromium)
5 years, 9 months ago (2015-03-10 03:55:17 UTC) #2
Matt Giuca
As discussed, if you are planning to remove all of the other code for M43, ...
5 years, 9 months ago (2015-03-10 06:18:16 UTC) #3
Anand Mistry (off Chromium)
On 2015/03/10 06:18:16, Matt Giuca wrote: > As discussed, if you are planning to remove ...
5 years, 9 months ago (2015-03-10 06:42:22 UTC) #4
Matt Giuca
OK, lgtm, assuming the next one is going to land in the next few days ...
5 years, 9 months ago (2015-03-11 21:26:43 UTC) #5
Anand Mistry (off Chromium)
thestig@chromium.org: For OWNERS.
5 years, 9 months ago (2015-03-11 23:49:19 UTC) #7
Lei Zhang
lgtm
5 years, 9 months ago (2015-03-11 23:53:21 UTC) #8
kcarattini
On 2015/03/11 23:53:21, Lei Zhang wrote: > lgtm This cl is also removing the field ...
5 years, 9 months ago (2015-03-12 03:44:22 UTC) #9
Anand Mistry (off Chromium)
On 2015/03/12 03:44:22, kcarattini wrote: > On 2015/03/11 23:53:21, Lei Zhang wrote: > > lgtm ...
5 years, 9 months ago (2015-03-12 04:40:09 UTC) #10
kcarattini
lgtm I'd just like the cl description to accurately reflect which cl it's in. If ...
5 years, 9 months ago (2015-03-12 08:13:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981773003/60001
5 years, 9 months ago (2015-03-17 00:20:09 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-17 01:57:09 UTC) #15
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 01:58:03 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5ded0c90a0d0b68a5b467cc9abcf3a0396d45b9c
Cr-Commit-Position: refs/heads/master@{#320843}

Powered by Google App Engine
This is Rietveld 408576698