Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5186)

Unified Diff: chrome/browser/extensions/hotword_browsertest.cc

Issue 981773003: Remove the flag to disable new hotwording. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/search/hotword_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/hotword_browsertest.cc
diff --git a/chrome/browser/extensions/hotword_browsertest.cc b/chrome/browser/extensions/hotword_browsertest.cc
index 753a7981c20ed351293edd39843eea6d9d238cc2..dcde7180b194feb0e4edc1507b31b0d06392d4c0 100644
--- a/chrome/browser/extensions/hotword_browsertest.cc
+++ b/chrome/browser/extensions/hotword_browsertest.cc
@@ -35,9 +35,6 @@ class HotwordBrowserTest : public ExtensionBrowserTest {
// extension.
base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
switches::kForceFieldTrials, "VoiceTrigger/Install/");
- // This test is only valid with version 1 of hotwording.
- base::CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kDisableExperimentalHotwording);
// Load the hotword_helper extension.
ComponentLoader::EnableBackgroundExtensionsForTesting();
@@ -70,7 +67,9 @@ class HotwordBrowserTest : public ExtensionBrowserTest {
// Test we silently capture an exception from a message handler's response
// callback. This happens when the caller to chrome.runtime.sendMessage()
// doesn't specify a response callback.
-IN_PROC_BROWSER_TEST_F(HotwordBrowserTest, MessageSendResponseError) {
+// NOTE(amistry): Test is disabled instead of deleted since the functionality
+// may still be required to implement crbug.com/436681
+IN_PROC_BROWSER_TEST_F(HotwordBrowserTest, DISABLED_MessageSendResponseError) {
// Enable error reporting for the hotword helper extension.
error_console()->SetReportingAllForExtension(kHotwordHelperExtensionId, true);
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/search/hotword_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698