Fix LibjingleTransportFactory to refresh STUN/Relay.

Fix LibjingleTransportFactory to refresh STUN/Relay.

Previously chromoting host would get relay info only when started. Relay
token expires within several hours, which means relay session creation would
always fail from the host running for longer than several hours, and that
makes connection impossible in some configurations. Moved code that
gets Jingle info to LibjingleTransportFactory and it's responsible for
refreshing relay token every hour.

BUG=318897
R=rmsousa@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240926

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240997

[rmsousa, 2013-12-13 22:10:39]

lgtm w/ comments

https://codereview.chromium.org/98173006/diff/40001/remoting/protocol/jingle_...
File remoting/protocol/jingle_session_manager.cc (right):

https://codereview.chromium.org/98173006/diff/40001/remoting/protocol/jingle_...
remoting/protocol/jingle_session_manager.cc:84:
listener_->OnSessionManagerReady();
Should we invalidate the transport factory tokens (regardless of age) if we get
disconnected and reconnected? I think we'd need to if the authentication tokens
are somehow bound to current IP or current JID (since they could have changed in
the disconnect/reconnect cycle), but I don't know if that's the case.

https://codereview.chromium.org/98173006/diff/40001/remoting/protocol/jingle_...
File remoting/protocol/jingle_session_manager.h (right):

https://codereview.chromium.org/98173006/diff/40001/remoting/protocol/jingle_...
remoting/protocol/jingle_session_manager.h:47: // JingleSessionManager will also
try to query configuration of STUN
Nit: clean up comment

https://codereview.chromium.org/98173006/diff/40001/remoting/protocol/libjing...
File remoting/protocol/libjingle_transport_factory.cc (right):

https://codereview.chromium.org/98173006/diff/40001/remoting/protocol/libjing...
remoting/protocol/libjingle_transport_factory.cc:463:
jingle_info_request_->Send(base::Bind(
is this safe if the signal_strategy_ is currently in the disconnected state?

https://codereview.chromium.org/98173006/diff/40001/remoting/protocol/libjing...
File remoting/protocol/libjingle_transport_factory.h (right):

https://codereview.chromium.org/98173006/diff/40001/remoting/protocol/libjing...
remoting/protocol/libjingle_transport_factory.h:42: SignalStrategy*
signal_strategy,
Nit: Can you document why this pointer is safe?

[Sergey Ulanov, 2013-12-13 23:54:33]

https://codereview.chromium.org/98173006/diff/40001/remoting/protocol/jingle_...
File remoting/protocol/jingle_session_manager.cc (right):

https://codereview.chromium.org/98173006/diff/40001/remoting/protocol/jingle_...
remoting/protocol/jingle_session_manager.cc:84:
listener_->OnSessionManagerReady();
On 2013/12/13 22:10:40, rmsousa wrote:
> Should we invalidate the transport factory tokens (regardless of age) if we
get
> disconnected and reconnected? I think we'd need to if the authentication
tokens
> are somehow bound to current IP or current JID (since they could have changed
in
> the disconnect/reconnect cycle), but I don't know if that's the case.

AFAICT token lifetime is not connected to IP or JID.

https://codereview.chromium.org/98173006/diff/40001/remoting/protocol/jingle_...
File remoting/protocol/jingle_session_manager.h (right):

https://codereview.chromium.org/98173006/diff/40001/remoting/protocol/jingle_...
remoting/protocol/jingle_session_manager.h:47: // JingleSessionManager will also
try to query configuration of STUN
On 2013/12/13 22:10:40, rmsousa wrote:
> Nit: clean up comment

Done.

https://codereview.chromium.org/98173006/diff/40001/remoting/protocol/libjing...
File remoting/protocol/libjingle_transport_factory.cc (right):

https://codereview.chromium.org/98173006/diff/40001/remoting/protocol/libjing...
remoting/protocol/libjingle_transport_factory.cc:463:
jingle_info_request_->Send(base::Bind(
On 2013/12/13 22:10:40, rmsousa wrote:
> is this safe if the signal_strategy_ is currently in the disconnected state?

JingleInfoRequest didn't handle this case properly. Fixed now.

https://codereview.chromium.org/98173006/diff/40001/remoting/protocol/libjing...
File remoting/protocol/libjingle_transport_factory.h (right):

https://codereview.chromium.org/98173006/diff/40001/remoting/protocol/libjing...
remoting/protocol/libjingle_transport_factory.h:42: SignalStrategy*
signal_strategy,
On 2013/12/13 22:10:40, rmsousa wrote:
> Nit: Can you document why this pointer is safe?

Done.

[commit-bot: I haz the power, 2013-12-14 06:31:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/98173006/100001

[commit-bot: I haz the power, 2013-12-14 07:04:06]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-12-14 07:53:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/98173006/100001

[commit-bot: I haz the power, 2013-12-14 08:24:33]

Retried try job too often on android_clang_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...

[commit-bot: I haz the power, 2013-12-14 08:33:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/98173006/100001

[commit-bot: I haz the power, 2013-12-14 09:03:38]

Retried try job too often on android_clang_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...

[commit-bot: I haz the power, 2013-12-14 17:56:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/98173006/100001

[commit-bot: I haz the power, 2013-12-14 18:32:37]

Retried try job too often on android_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[commit-bot: I haz the power, 2013-12-14 22:46:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/98173006/100001

[commit-bot: I haz the power, 2013-12-14 23:13:22]

Retried try job too often on android_clang_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...

[commit-bot: I haz the power, 2013-12-15 03:02:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/98173006/100001

[commit-bot: I haz the power, 2013-12-15 03:38:57]

Retried try job too often on android_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[commit-bot: I haz the power, 2013-12-15 22:47:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/98173006/100001

[commit-bot: I haz the power, 2013-12-15 23:23:59]

Retried try job too often on android_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[commit-bot: I haz the power, 2013-12-16 09:35:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/98173006/100001

[commit-bot: I haz the power, 2013-12-16 10:25:16]

Retried try job too often on android_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[Sergey Ulanov, 2013-12-16 18:08:47]

Committed patchset #3 manually as r240926 (presubmit successful).

[commit-bot: I haz the power, 2013-12-16 18:27:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/98173006/120001

[Sergey Ulanov, 2013-12-16 20:09:43]

Committed patchset #4 manually as r240997 (presubmit successful).