Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1188)

Unified Diff: remoting/jingle_glue/jingle_info_request.h

Issue 98173006: Fix LibjingleTransportFactory to refresh STUN/Relay. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/session_manager_factory.cc ('k') | remoting/jingle_glue/jingle_info_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/jingle_glue/jingle_info_request.h
diff --git a/remoting/jingle_glue/jingle_info_request.h b/remoting/jingle_glue/jingle_info_request.h
index a1b10dead931f959bc75d5554e048f5d83dd222e..118aa4a17fc1fd9639e4fcf06f312ce699091583 100644
--- a/remoting/jingle_glue/jingle_info_request.h
+++ b/remoting/jingle_glue/jingle_info_request.h
@@ -13,7 +13,6 @@
#include "base/callback.h"
#include "base/memory/scoped_ptr.h"
#include "remoting/jingle_glue/iq_sender.h"
-#include "third_party/libjingle/source/talk/base/sigslot.h"
namespace buzz {
class XmlElement;
@@ -34,17 +33,14 @@ class SignalStrategy;
//
// This class is not threadsafe and should be used on the same thread it is
// created on.
-//
-// TODO(ajwong): Add support for a timeout.
-class JingleInfoRequest : public sigslot::has_slots<> {
+class JingleInfoRequest {
public:
- // Callback to receive the Jingle configuration settings. The arguments are
- // passed by pointer so the receive may call swap on them. The receiver does
- // NOT own the arguments, which are guaranteed only to be alive for the
- // duration of the callback.
- typedef base::Callback<void (
- const std::string&, const std::vector<std::string>&,
- const std::vector<talk_base::SocketAddress>&)> OnJingleInfoCallback;
+ // Callback to receive the Jingle configuration settings. All fields are empty
+ // if the request has timed out.
+ typedef base::Callback<void(const std::string& relay_token,
+ const std::vector<std::string>& relay_servers,
+ const std::vector<talk_base::SocketAddress>&
+ stun_servers)> OnJingleInfoCallback;
explicit JingleInfoRequest(SignalStrategy* signal_strategy);
virtual ~JingleInfoRequest();
« no previous file with comments | « remoting/host/session_manager_factory.cc ('k') | remoting/jingle_glue/jingle_info_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698