Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 981693002: MacViews: Fix crash when EventMonitorMac receives a NSSystemDefinedEvent (Closed)

Created:
5 years, 9 months ago by Andre
Modified:
5 years, 9 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, tfarina, jdduke+watch_chromium.org, tdresser+watch_chromium.org, mac-views-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@views
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Fix crash when EventMonitorMac receives a system defined event. EventFromNative() returns null when given a system defined event, so filter them out when monitoring the event stream. When running the experimental MacViews browser, I was seeing an event with type=SysDefined subtype=7 (apparently it means that a mouse button state has changed). BUG=425229 Committed: https://crrev.com/40b0d46d7c7660cb8cb8bfc68df1b233f0811cd3 Cr-Commit-Position: refs/heads/master@{#319142}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ui/events/cocoa/events_mac.mm View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/event_monitor_mac.mm View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Andre
Avi, please review.
5 years, 9 months ago (2015-03-04 21:51:41 UTC) #2
Avi (use Gerrit)
lgtm
5 years, 9 months ago (2015-03-04 22:00:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981693002/1
5 years, 9 months ago (2015-03-04 22:08:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 22:29:04 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 22:30:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/40b0d46d7c7660cb8cb8bfc68df1b233f0811cd3
Cr-Commit-Position: refs/heads/master@{#319142}

Powered by Google App Engine
This is Rietveld 408576698