ui/events/cocoa/events_mac.mm - Issue 981693002: MacViews: Fix crash when EventMonitorMac receives a NSSystemDefinedEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/cocoa/events_mac.mm

Issue 981693002: MacViews: Fix crash when EventMonitorMac receives a NSSystemDefinedEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@views

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/events/cocoa/events_mac.mm

diff --git a/ui/events/cocoa/events_mac.mm b/ui/events/cocoa/events_mac.mm

index d21184cc07eff9ce9d47cf452a886c17b10c27ca..64eb972e15e25c225ed9ba2ca939444ec572025e 100644

--- a/ui/events/cocoa/events_mac.mm

+++ b/ui/events/cocoa/events_mac.mm

@@ -52,9 +52,10 @@ EventType EventTypeFromNative(const base::NativeEvent& native_event) {

return ET_MOUSE_EXITED;

case NSEventTypeSwipe:

return ET_SCROLL_FLING_START;

- case NSFlagsChanged:

case NSAppKitDefined:

case NSSystemDefined:

+ return ET_UNKNOWN;

+ case NSFlagsChanged:

case NSApplicationDefined:

case NSPeriodic:

case NSCursorUpdate:

« no previous file with comments | « no previous file | ui/views/event_monitor_mac.mm » ('j') | no next file with comments »