net/url_request/url_request_test_util.h - Issue 981633002: Created new URLRequestContext for secure proxy check

Unified Diff: net/url_request/url_request_test_util.h

Issue 981633002: Created new URLRequestContext for secure proxy check (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved Secure Proxy check to separate class. Addressed comments. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc ('K') | « components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/url_request/url_request_test_util.h

diff --git a/net/url_request/url_request_test_util.h b/net/url_request/url_request_test_util.h

index 9ad66a14aa1727f1ed9d33089be1882ff23570f0..096847abd3f0a448525e523f53dfdc05eb580f4a 100644

--- a/net/url_request/url_request_test_util.h

+++ b/net/url_request/url_request_test_util.h

@@ -70,7 +70,9 @@ class TestURLRequestContext : public URLRequestContext {

}

void set_http_network_session_params(

- const HttpNetworkSession::Params& params) {

+ const HttpNetworkSession::Params* params) {

+ http_network_session_params_.reset(

+ const_cast<HttpNetworkSession::Params*>(params));

sclittle 2015/04/02 00:07:00 You should never have to cast a const pointer to a

tbansal1 2015/04/02 23:21:20 Done. Except not moved into the .cc file to stay c

sclittle 2015/04/03 02:06:56 Could you pass in a scoped_ptr instead, so that it

tbansal1 2015/04/03 22:14:43 Not moved to C++ file. There are lot of other code

}

void SetSdchManager(scoped_ptr<SdchManager> sdch_manager) {