Created new URLRequestContext for secure proxy check

net/url_request/url_request_test_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_URL_REQUEST_URL_REQUEST_TEST_UTIL_H_
 #define NET_URL_REQUEST_URL_REQUEST_TEST_UTIL_H_
 
 #include <stdlib.h>
 
 #include <map>
@@ skipping 52 matching lines @@
   void Init();
 
   ClientSocketFactory* client_socket_factory() {
     return client_socket_factory_;
   }
   void set_client_socket_factory(ClientSocketFactory* factory) {
     client_socket_factory_ = factory;
   }
 
   void set_http_network_session_params(
-      const HttpNetworkSession::Params& params) {
+      const HttpNetworkSession::Params* params) {
+    http_network_session_params_.reset(
+        const_cast<HttpNetworkSession::Params*>(params));

[sclittle, 2015/04/02 00:07:00]

You should never have to cast a const pointer to a non-const pointer.

Instead you could pass in a scoped_ptr<HttpNetworkSession::Params> and take
ownership of it.

Also, move the implementation of this method into the .cc file.

[tbansal1, 2015/04/02 23:21:20]

Done. Except not moved into the .cc file to stay consistent with other set*
functions in this class.

[sclittle, 2015/04/03 02:06:56]

Could you pass in a scoped_ptr instead, so that it's obvious that the
TestURLRequestContext takes ownership of the params?

Also, the implementation here should be moved to the .cc file instead of being
inlined in the header file here:
https://www.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Stop-i...

[tbansal1, 2015/04/03 22:14:43]

Not moved to C++ file. There are lot of other code thats making use of the
functions in this class. Probably should be done in a separate cleanup-CL.

   }
 
   void SetSdchManager(scoped_ptr<SdchManager> sdch_manager) {
     context_storage_.set_sdch_manager(sdch_manager.Pass());
   }
 
  private:
   bool initialized_;
 
   // Optional parameters to override default values.  Note that values that
@@ skipping 327 matching lines @@
       NetworkDelegate* network_delegate) const override;
   void set_main_intercept_job(URLRequestJob* job);
 
  private:
   mutable URLRequestJob* main_intercept_job_;
 };
 
 }  // namespace net
 
 #endif  // NET_URL_REQUEST_URL_REQUEST_TEST_UTIL_H_