Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 981583005: [Ozone-Dri] Merge the DriWindowDelegate with the implementation (Closed)

Created:
5 years, 9 months ago by dnicoara
Modified:
5 years, 9 months ago
Reviewers:
spang
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Ozone-Dri] Merge the DriWindowDelegate with the implementation Simplify code by removing an interface only used in testing. BUG=none Committed: https://crrev.com/2941af41fb7cfee4ca57388e410f9838ac5c0b26 Cr-Commit-Position: refs/heads/master@{#319160}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -574 lines) Patch
M ui/ozone/platform/dri/BUILD.gn View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/ozone/platform/dri/dri.gypi View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/ozone/platform/dri/dri_gpu_platform_support.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/dri/dri_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/dri/dri_surface_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/dri/dri_surface_unittest.cc View 6 chunks +38 lines, -43 lines 0 comments Download
M ui/ozone/platform/dri/dri_window_delegate.h View 2 chunks +73 lines, -27 lines 0 comments Download
A + ui/ozone/platform/dri/dri_window_delegate.cc View 8 chunks +26 lines, -27 lines 0 comments Download
D ui/ozone/platform/dri/dri_window_delegate_impl.h View 1 chunk +0 lines, -88 lines 0 comments Download
D ui/ozone/platform/dri/dri_window_delegate_impl.cc View 1 chunk +0 lines, -219 lines 0 comments Download
D ui/ozone/platform/dri/dri_window_delegate_impl_unittest.cc View 1 chunk +0 lines, -146 lines 0 comments Download
A + ui/ozone/platform/dri/dri_window_delegate_unittest.cc View 6 chunks +10 lines, -12 lines 0 comments Download
M ui/ozone/platform/dri/gbm_surface_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/dri/ozone_platform_dri.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dnicoara
PTAL I was going to do this after moving and renaming all the files, but ...
5 years, 9 months ago (2015-03-04 20:41:03 UTC) #2
spang
lgtm
5 years, 9 months ago (2015-03-04 20:42:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981583005/1
5 years, 9 months ago (2015-03-04 22:42:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 23:22:04 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 23:23:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2941af41fb7cfee4ca57388e410f9838ac5c0b26
Cr-Commit-Position: refs/heads/master@{#319160}

Powered by Google App Engine
This is Rietveld 408576698