Change all sources associated with changed files (issue 22680)

pkg/analysis_server/lib/src/context_manager.dart

Index: pkg/analysis_server/lib/src/context_manager.dart
diff --git a/pkg/analysis_server/lib/src/context_manager.dart b/pkg/analysis_server/lib/src/context_manager.dart
index 8af64b3f40d93bef9ec327223660860c200bfc75..1506fc5375a8b70ec664ecc07a1f2f8dcc837148 100644
--- a/pkg/analysis_server/lib/src/context_manager.dart
+++ b/pkg/analysis_server/lib/src/context_manager.dart
@@ -518,10 +518,12 @@ abstract class ContextManager {
         }
         break;
       case ChangeType.MODIFY:
-        Source source = info.sources[path];
-        if (source != null) {
+        List<Source> sources = info.context.getSourcesWithFullName(path);

[Paul Berry, 2015/03/06 21:56:42]

I just noticed that there's a pre-existing bug here: if a file is explicitly
included in one context but implicitly referenced in another context, we'll only
send a changeSet to the context that explicitly includes the file (since that's
the only context that's watching the file).  Would you mind adding a TODO
comment to this effect?

[Brian Wilkerson, 2015/03/06 23:17:11]

Done.

+        if (!sources.isEmpty) {
           ChangeSet changeSet = new ChangeSet();
-          changeSet.changedSource(source);
+          sources.forEach((Source source) {

[Paul Berry, 2015/03/06 21:56:42]

Nit: this is inefficient since it copies Source objects one at a time from the
"sources" list (which is about to be GC'ed) to the newly allocated
changeSet.changedSources list.

Consider replacing this with just:

changeSet.changedSources = sources;

[Brian Wilkerson, 2015/03/06 23:17:11]

Yes it is. But the field is 'final', so making it more efficient would require
bigger changes.

[Paul Berry, 2015/03/09 18:05:33]

Fair enough.

+            changeSet.changedSource(source);
+          });
           applyChangesToContext(folder, changeSet);
         }
         break;