Change all sources associated with changed files (issue 22680)

pkg/analysis_server/lib/src/context_manager.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library context.directory.manager;
 
 import 'dart:async';
 import 'dart:collection';
 
 import 'package:analysis_server/src/analysis_server.dart';
@@ skipping 500 matching lines @@
         }
         Source source = info.sources[path];
         if (source != null) {
           ChangeSet changeSet = new ChangeSet();
           changeSet.removedSource(source);
           applyChangesToContext(folder, changeSet);
           info.sources.remove(path);
         }
         break;
       case ChangeType.MODIFY:
-        Source source = info.sources[path];
-        if (source != null) {
+        List<Source> sources = info.context.getSourcesWithFullName(path);

[Paul Berry, 2015/03/06 21:56:42]

I just noticed that there's a pre-existing bug here: if a file is explicitly
included in one context but implicitly referenced in another context, we'll only
send a changeSet to the context that explicitly includes the file (since that's
the only context that's watching the file).  Would you mind adding a TODO
comment to this effect?

[Brian Wilkerson, 2015/03/06 23:17:11]

Done.

+        if (!sources.isEmpty) {
           ChangeSet changeSet = new ChangeSet();
-          changeSet.changedSource(source);
+          sources.forEach((Source source) {

[Paul Berry, 2015/03/06 21:56:42]

Nit: this is inefficient since it copies Source objects one at a time from the
"sources" list (which is about to be GC'ed) to the newly allocated
changeSet.changedSources list.

Consider replacing this with just:

changeSet.changedSources = sources;

[Brian Wilkerson, 2015/03/06 23:17:11]

Yes it is. But the field is 'final', so making it more efficient would require
bigger changes.

[Paul Berry, 2015/03/09 18:05:33]

Fair enough.

+            changeSet.changedSource(source);
+          });
           applyChangesToContext(folder, changeSet);
         }
         break;
     }
 
     if (info.packageMapDependencies.contains(path)) {
       _recomputePackageUriResolver(info);
     }
   }
 
@@ skipping 175 matching lines @@
     return excludes(resource.path);
   }
 
   /**
    * Returns `true` if [path] is the pubspec file of this context.
    */
   bool isPubspec(String path) {
     return path == pubspecPath;
   }
 }