chrome/browser/ssl/ssl_blocking_page.h - Issue 981243003: Make commands consistent across security interstitials

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/ssl_blocking_page.h

Issue 981243003: Make commands consistent across security interstitials (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated test Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ssl/captive_portal_blocking_page.cc ('K') | « chrome/browser/ssl/captive_portal_blocking_page.cc ('k') | chrome/browser/ssl/ssl_blocking_page.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ssl/ssl_blocking_page.h

diff --git a/chrome/browser/ssl/ssl_blocking_page.h b/chrome/browser/ssl/ssl_blocking_page.h

index 6d427c1bd84b36229787569b2b9891facf31bf8d..0472e39026e83e5c0c12fb8d252b65892f0dac7c 100644

--- a/chrome/browser/ssl/ssl_blocking_page.h

+++ b/chrome/browser/ssl/ssl_blocking_page.h

@@ -30,18 +30,6 @@ class SSLErrorClassification;

// It deletes itself when the interstitial page is closed.

class SSLBlockingPage : public SecurityInterstitialPage {

public:

- // These represent the commands sent from the interstitial JavaScript. They

- // are defined in chrome/browser/resources/ssl/ssl_errors_common.js.

- // DO NOT reorder or change these without also changing the JavaScript!

- enum SSLBlockingPageCommands {

- CMD_DONT_PROCEED = 0,

- CMD_PROCEED = 1,

- CMD_MORE = 2,

- CMD_RELOAD = 3,

- CMD_HELP = 4,

- CMD_CLOCK = 5

- };

enum SSLBlockingPageOptionsMask {

// Indicates whether or not the user could (assuming perfect knowledge)

// successfully override the error and still get the security guarantees