Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1866)

Unified Diff: chrome/browser/ssl/ssl_blocking_page.cc

Issue 981243003: Make commands consistent across security interstitials (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated test Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_blocking_page.cc
diff --git a/chrome/browser/ssl/ssl_blocking_page.cc b/chrome/browser/ssl/ssl_blocking_page.cc
index 2dd3c51a9329e4807d4ce770a425e874c6988726..4949195953711d0f1a424a27862890e2f8c3c918 100644
--- a/chrome/browser/ssl/ssl_blocking_page.cc
+++ b/chrome/browser/ssl/ssl_blocking_page.cc
@@ -467,19 +467,12 @@ void SSLBlockingPage::CommandReceived(const std::string& command) {
}
break;
}
- case CMD_MORE: {
+ case CMD_SHOW_MORE_SECTION: {
metrics_helper_->RecordUserInteraction(
SecurityInterstitialMetricsHelper::SHOW_ADVANCED);
break;
}
- case CMD_RELOAD: {
- metrics_helper_->RecordUserInteraction(
- SecurityInterstitialMetricsHelper::RELOAD);
- // The interstitial can't refresh itself.
- web_contents()->GetController().Reload(true);
- break;
- }
- case CMD_HELP: {
+ case CMD_OPEN_HELP_CENTER: {
metrics_helper_->RecordUserInteraction(
SecurityInterstitialMetricsHelper::SHOW_LEARN_MORE);
content::NavigationController::LoadURLParams help_page_params(
@@ -488,12 +481,26 @@ void SSLBlockingPage::CommandReceived(const std::string& command) {
web_contents()->GetController().LoadURLWithParams(help_page_params);
break;
}
- case CMD_CLOCK: {
+ case CMD_RELOAD: {
+ metrics_helper_->RecordUserInteraction(
+ SecurityInterstitialMetricsHelper::RELOAD);
+ // The interstitial can't refresh itself.
+ web_contents()->GetController().Reload(true);
+ break;
+ }
+ case CMD_OPEN_DATE_SETTINGS: {
metrics_helper_->RecordUserInteraction(
SecurityInterstitialMetricsHelper::OPEN_TIME_SETTINGS);
LaunchDateAndTimeSettings();
break;
}
+ case CMD_OPEN_DIAGNOSTIC:
+ // Google doesn't currently have a transparency report for SSL.
+ case CMD_DO_REPORT:
+ case CMD_DONT_REPORT:
+ case CMD_OPEN_REPORTING_PRIVACY:
+ // Chrome doesn't currently do Extended Reporting for SSL.
+ break;
default: {
NOTREACHED();
}

Powered by Google App Engine
This is Rietveld 408576698