Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5498)

Unified Diff: chrome/browser/interstitials/security_interstitial_page.h

Issue 981243003: Make commands consistent across security interstitials (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: if -> switch in SafeBrowsingBlockingPage Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/interstitials/security_interstitial_page.h
diff --git a/chrome/browser/interstitials/security_interstitial_page.h b/chrome/browser/interstitials/security_interstitial_page.h
index 98e8e197eeb6f766f42631fe9c890f1764e0ca36..44f2ad8ecfbcaf2ca6eba2dee959f9bb37984fa2 100644
--- a/chrome/browser/interstitials/security_interstitial_page.h
+++ b/chrome/browser/interstitials/security_interstitial_page.h
@@ -20,6 +20,27 @@ class WebContents;
class SecurityInterstitialPage : public content::InterstitialPageDelegate {
public:
+ // These represent the commands sent from the interstitial JavaScript.
+ // DO NOT reorder or change these without also changing the JavaScript!
+ // See chrome/browser/resources/security_warnings/interstitial_v2.js
+ enum SecurityInterstitialCommands {
+ // Decisions
+ CMD_DONT_PROCEED = 0,
+ CMD_PROCEED = 1,
+ // Ways for user to get more information
+ CMD_SHOW_MORE_SECTION = 2,
+ CMD_OPEN_HELP_CENTER = 3,
+ CMD_OPEN_DIAGNOSTIC = 4,
+ // Primary button actions
+ CMD_RELOAD = 5,
+ CMD_OPEN_DATE_SETTINGS = 6,
+ CMD_OPEN_LOGIN = 7,
+ // Safe Browsing Extended Reporting
+ CMD_DO_REPORT = 8,
+ CMD_DONT_REPORT = 9,
+ CMD_OPEN_REPORTING_PRIVACY = 10,
+ };
+
SecurityInterstitialPage(content::WebContents* web_contents,
const GURL& url);
~SecurityInterstitialPage() override;
« no previous file with comments | « no previous file | chrome/browser/resources/security_warnings/interstitial_v2.js » ('j') | chrome/browser/ssl/ssl_blocking_page.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698