Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: chrome/browser/interstitials/security_interstitial_page.h

Issue 981243003: Make commands consistent across security interstitials (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: if -> switch in SafeBrowsingBlockingPage Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_INTERSTITIALS_SECURITY_INTERSTITIAL_PAGE_H_ 5 #ifndef CHROME_BROWSER_INTERSTITIALS_SECURITY_INTERSTITIAL_PAGE_H_
6 #define CHROME_BROWSER_INTERSTITIALS_SECURITY_INTERSTITIAL_PAGE_H_ 6 #define CHROME_BROWSER_INTERSTITIALS_SECURITY_INTERSTITIAL_PAGE_H_
7 7
8 #include "base/strings/string16.h" 8 #include "base/strings/string16.h"
9 #include "content/public/browser/interstitial_page_delegate.h" 9 #include "content/public/browser/interstitial_page_delegate.h"
10 #include "url/gurl.h" 10 #include "url/gurl.h"
11 11
12 namespace base { 12 namespace base {
13 class DictionaryValue; 13 class DictionaryValue;
14 } 14 }
15 15
16 namespace content { 16 namespace content {
17 class InterstitialPage; 17 class InterstitialPage;
18 class WebContents; 18 class WebContents;
19 } 19 }
20 20
21 class SecurityInterstitialPage : public content::InterstitialPageDelegate { 21 class SecurityInterstitialPage : public content::InterstitialPageDelegate {
22 public: 22 public:
23 // These represent the commands sent from the interstitial JavaScript.
24 // DO NOT reorder or change these without also changing the JavaScript!
25 // See chrome/browser/resources/security_warnings/interstitial_v2.js
26 enum SecurityInterstitialCommands {
27 // Decisions
28 CMD_DONT_PROCEED = 0,
29 CMD_PROCEED = 1,
30 // Ways for user to get more information
31 CMD_SHOW_MORE_SECTION = 2,
32 CMD_OPEN_HELP_CENTER = 3,
33 CMD_OPEN_DIAGNOSTIC = 4,
34 // Primary button actions
35 CMD_RELOAD = 5,
36 CMD_OPEN_DATE_SETTINGS = 6,
37 CMD_OPEN_LOGIN = 7,
38 // Safe Browsing Extended Reporting
39 CMD_DO_REPORT = 8,
40 CMD_DONT_REPORT = 9,
41 CMD_OPEN_REPORTING_PRIVACY = 10,
42 };
43
23 SecurityInterstitialPage(content::WebContents* web_contents, 44 SecurityInterstitialPage(content::WebContents* web_contents,
24 const GURL& url); 45 const GURL& url);
25 ~SecurityInterstitialPage() override; 46 ~SecurityInterstitialPage() override;
26 47
27 // Creates an interstitial and shows it. 48 // Creates an interstitial and shows it.
28 virtual void Show(); 49 virtual void Show();
29 50
30 // Returns interstitial type for testing. 51 // Returns interstitial type for testing.
31 virtual const void* GetTypeForTesting() const = 0; 52 virtual const void* GetTypeForTesting() const = 0;
32 53
(...skipping 24 matching lines...) Expand all
57 // Once shown, |interstitial_page| takes ownership of this 78 // Once shown, |interstitial_page| takes ownership of this
58 // SecurityInterstitialPage instance. 79 // SecurityInterstitialPage instance.
59 content::InterstitialPage* interstitial_page_; 80 content::InterstitialPage* interstitial_page_;
60 // Whether the interstitial should create a view. 81 // Whether the interstitial should create a view.
61 bool create_view_; 82 bool create_view_;
62 83
63 DISALLOW_COPY_AND_ASSIGN(SecurityInterstitialPage); 84 DISALLOW_COPY_AND_ASSIGN(SecurityInterstitialPage);
64 }; 85 };
65 86
66 #endif // CHROME_BROWSER_INTERSTITIALS_SECURITY_INTERSTITIAL_PAGE_H_ 87 #endif // CHROME_BROWSER_INTERSTITIALS_SECURITY_INTERSTITIAL_PAGE_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/security_warnings/interstitial_v2.js » ('j') | chrome/browser/ssl/ssl_blocking_page.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698