chrome/browser/resources/settings/settings_menu/settings_menu.html - Issue 981203007: Scaffold for MD-Settings.

Unified Diff: chrome/browser/resources/settings/settings_menu/settings_menu.html

Issue 981203007: Scaffold for MD-Settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Feedback. Update core-selected-pages usage. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/settings_menu/settings_menu.html

diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.html b/chrome/browser/resources/settings/settings_menu/settings_menu.html

new file mode 100644

index 0000000000000000000000000000000000000000..f8e27eadbbdcd3aa630781594d60c429232b0e25

--- /dev/null

+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.html

@@ -0,0 +1,17 @@

+<link rel="import" href="chrome://resources/polymer/core-menu/core-menu.html">

+<link rel="import" href="chrome://resources/polymer/paper-item/paper-item.html">

+<polymer-element name="cr-settings-menu">

+ <template>

+ <link rel="stylesheet" href="settings_menu.css">

+ <core-menu id="menu" selected="{{selectedId}}" valueattr="id">

+ <template repeat="{{pages}}">

+ <paper-item id="{{PAGE_ID}}">

Jeremy Klein 2015/03/12 02:11:18 nit: Is there any reason we need to use the id att

michaelpg 2015/03/12 06:29:37 Done.

+ <core-icon icon="{{icon}}"></core-icon>

+ {{pageTitle}}

Jeremy Klein 2015/03/12 02:11:18 Shouldn't we add a pageTitle and icon to the a11y

michaelpg 2015/03/12 06:29:37 yes, those should have been there -- i'm doing a b

Jeremy Klein 2015/03/12 06:46:36 No worries, it's hard to untangle lots of commits

+ </paper-item>

+ </template>

+ </core-menu>

+ </template>

+ <script src="settings_menu.js"></script>

+</polymer-element>