chrome/browser/resources/settings/settings_menu/settings_menu.html - Issue 981203007: Scaffold for MD-Settings.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/settings_menu/settings_menu.html

Issue 981203007: Scaffold for MD-Settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Feedback. Update core-selected-pages usage. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/settings_main/settings_main.js ('K') | « chrome/browser/resources/settings/settings_menu/settings_menu.css ('k') | chrome/browser/resources/settings/settings_menu/settings_menu.js » ('j') | chrome/browser/resources/settings/settings_ui/settings_ui.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/polymer/core-menu/core-menu.html">

	2 <link rel="import" href="chrome://resources/polymer/paper-item/paper-item.html">

	3

	4 <polymer-element name="cr-settings-menu">

	5 <template>

	6 <link rel="stylesheet" href="settings_menu.css">

	7 <core-menu id="menu" selected="{{selectedId}}" valueattr="id">

	8 <template repeat="{{pages}}">

	9 <paper-item id="{{PAGE_ID}}">
	Jeremy Klein 2015/03/12 02:11:18 nit: Is there any reason we need to use the id att nit: Is there any reason we need to use the id attribute here? I'd rather just call it pageId or something to avoid confusion. michaelpg 2015/03/12 06:29:37 Done. Show quoted text On 2015/03/12 02:11:18, Jeremy Klein wrote: > nit: Is there any reason we need to use the id attribute here? I'd rather just > call it pageId or something to avoid confusion. Done.
	10 <core-icon icon="{{icon}}"></core-icon>

	11 {{pageTitle}}
	Jeremy Klein 2015/03/12 02:11:18 Shouldn't we add a pageTitle and icon to the a11y Shouldn't we add a pageTitle and icon to the a11y page? michaelpg 2015/03/12 06:29:37 yes, those should have been there -- i'm doing a b Show quoted text On 2015/03/12 02:11:18, Jeremy Klein wrote: > Shouldn't we add a pageTitle and icon to the a11y page? yes, those should have been there -- i'm doing a bad job maintaining my branches :-( Jeremy Klein 2015/03/12 06:46:36 No worries, it's hard to untangle lots of commits Show quoted text On 2015/03/12 06:29:37, michaelpg wrote: > On 2015/03/12 02:11:18, Jeremy Klein wrote: > > Shouldn't we add a pageTitle and icon to the a11y page? > > yes, those should have been there -- i'm doing a bad job maintaining my branches > :-( No worries, it's hard to untangle lots of commits :-). Just today I accidentally put a file in the wrong CL twice haha.
	12 </paper-item>

	13 </template>

	14 </core-menu>

	15 </template>

	16 <script src="settings_menu.js"></script>

	17 </polymer-element>

OLD	NEW