Metrics provider for statistical stack profiler

components/metrics/proto/sampled_profile.proto

Index: components/metrics/proto/sampled_profile.proto
diff --git a/components/metrics/proto/sampled_profile.proto b/components/metrics/proto/sampled_profile.proto
index 1b8d66ff44fe6f083b8486d8826a37e304ca0d37..a43ace3c95d9494f6dd2b04530349d9f2f7aac36 100644
--- a/components/metrics/proto/sampled_profile.proto
+++ b/components/metrics/proto/sampled_profile.proto
@@ -9,11 +9,12 @@ option optimize_for = LITE_RUNTIME;
 package metrics;
 
 import "perf_data.proto";
+import "call_stack_profile.proto";

[Ilya Sherman, 2015/03/10 01:44:46]

nit: Please alphabetize.

[Mike Wittman, 2015/03/16 23:55:15]

Done.

 
 // Protocol buffer for collected sample-based profiling data.
 // Contains the parameters and data from a single profile collection event.
 
-// Next tag: 9
+// Next tag: 10
 message SampledProfile {
   // Indicates the event that triggered this collection.
   enum TriggerEvent {
@@ -59,6 +60,9 @@ message SampledProfile {
   // collected. Only set when |trigger_event| is RESTORE_SESSION.
   optional int64 ms_after_restore = 8;
 
-  // The actual perf data that was collected.
+  // Sample profile data collected from Linux perf tool.

[Ilya Sherman, 2015/03/10 01:44:46]

nit: "Sample" -> "Sampled"

[Mike Wittman, 2015/03/16 23:55:15]

Done.

   optional PerfDataProto perf_data = 4;
+
+  // Sample profile data collected by means other than Linux perf.

[Ilya Sherman, 2015/03/10 01:44:46]

nit: This is too vague.  Please be more specific.

[Mike Wittman, 2015/03/16 23:55:15]

Done.

+  optional CallStackProfile call_stack_profile = 9;

[Ilya Sherman, 2015/03/10 01:44:46]

Note that the same comments w.r.t. landing in google3 first apply to this CL as
well.

[Mike Wittman, 2015/03/16 23:55:15]

Acknowledged.

 }