Metrics provider for statistical stack profiler

components/metrics/proto/sampled_profile.proto

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 syntax = "proto2";
 
 option optimize_for = LITE_RUNTIME;
 
 package metrics;
 
 import "perf_data.proto";
+import "call_stack_profile.proto";

[Ilya Sherman, 2015/03/10 01:44:46]

nit: Please alphabetize.

[Mike Wittman, 2015/03/16 23:55:15]

Done.

 
 // Protocol buffer for collected sample-based profiling data.
 // Contains the parameters and data from a single profile collection event.
 
-// Next tag: 9
+// Next tag: 10
 message SampledProfile {
   // Indicates the event that triggered this collection.
   enum TriggerEvent {
     UNKNOWN_TRIGGER_EVENT = 0;
 
     // The profile was triggered by periodic sampling.  Periodically sampled
     // profiles are collected once per uniformly sized period interval.  Within
     // each interval, the sampled data is collected at a random time.  For
     // example, if the interval is 60 s, then data would be collected at a
     // random point in each of the intervals [0, 60 s), [60 s, 120 s), etc.
@@ skipping 25 matching lines @@
   optional int64 ms_after_resume = 6;
 
   // Number of tabs restored during a session restore. Only set when
   // |trigger_event| is RESTORE_SESSION.
   optional int32 num_tabs_restored = 7;
 
   // Number of milliseconds after a session restore that a profile was
   // collected. Only set when |trigger_event| is RESTORE_SESSION.
   optional int64 ms_after_restore = 8;
 
-  // The actual perf data that was collected.
+  // Sample profile data collected from Linux perf tool.

[Ilya Sherman, 2015/03/10 01:44:46]

nit: "Sample" -> "Sampled"

[Mike Wittman, 2015/03/16 23:55:15]

Done.

   optional PerfDataProto perf_data = 4;
+
+  // Sample profile data collected by means other than Linux perf.

[Ilya Sherman, 2015/03/10 01:44:46]

nit: This is too vague.  Please be more specific.

[Mike Wittman, 2015/03/16 23:55:15]

Done.

+  optional CallStackProfile call_stack_profile = 9;

[Ilya Sherman, 2015/03/10 01:44:46]

Note that the same comments w.r.t. landing in google3 first apply to this CL as
well.

[Mike Wittman, 2015/03/16 23:55:15]

Acknowledged.

 }