Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 981103002: Re-enable dart:sky in shelldb analyze. (Closed)

Created:
5 years, 9 months ago by eseidel
Modified:
5 years, 9 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Re-enable dart:sky in shelldb analyze. It show 600+ "native" warnings, but those can be ignored for now. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/30edf582d77b443b69fc9e8738c125f0844ce3eb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M sky/tools/shelldb View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
eseidel
5 years, 9 months ago (2015-03-06 00:16:05 UTC) #1
abarth-chromium
lgtm
5 years, 9 months ago (2015-03-06 00:18:22 UTC) #2
eseidel
5 years, 9 months ago (2015-03-06 00:22:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
30edf582d77b443b69fc9e8738c125f0844ce3eb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698