Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Unified Diff: sky/tools/shelldb

Issue 981103002: Re-enable dart:sky in shelldb analyze. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tools/shelldb
diff --git a/sky/tools/shelldb b/sky/tools/shelldb
index bdd3249a3640379f837fab22447141c4ead139e1..492129ae48bd31d17a4f2bd828c92b51d2924c23 100755
--- a/sky/tools/shelldb
+++ b/sky/tools/shelldb
@@ -208,8 +208,7 @@ class Analyze(object):
os.path.join(SRC_ROOT, 'mojo/public/dart/bindings.dart')
mojo_core_path = os.path.join(SRC_ROOT, 'mojo/public/dart/core.dart')
analyzer_args = [ANALYZER_PATH,
- # sky_core.dart does not compile cleanly yet. :(
- # "--url-mapping=dart:sky,%s" % dart_sky_path,
+ "--url-mapping=dart:sky,%s" % dart_sky_path,
"--url-mapping=dart:sky_builtin,%s" % sky_builtin_path,
"--url-mapping=mojo:bindings,%s" % mojo_bindings_path,
"--url-mapping=mojo:core,%s" % mojo_core_path,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698