ash/metrics/user_metrics_recorder.h - Issue 980943005: Add ash UI for third-party VPNs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/metrics/user_metrics_recorder.h

Issue 980943005: Add ash UI for third-party VPNs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@f_2_407541_434711_remove_combined_name

Patch Set: Added a VPNProvider::Key abstraction. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/metrics/user_metrics_recorder.h

diff --git a/ash/metrics/user_metrics_recorder.h b/ash/metrics/user_metrics_recorder.h

index 6347f65d640971008b5fd6151a091d1c76671006..8f7a58fc216236243cd2fe9502ed13f5ea0cd893 100644

--- a/ash/metrics/user_metrics_recorder.h

+++ b/ash/metrics/user_metrics_recorder.h

@@ -82,7 +82,9 @@ enum UserMetricsAction {

UMA_STATUS_AREA_SHOW_NETWORK_CONNECTION_DETAILS,

UMA_STATUS_AREA_SHOW_VPN_CONNECTION_DETAILS,

UMA_STATUS_AREA_SIGN_OUT,

- UMA_STATUS_AREA_VPN_JOIN_OTHER_CLICKED,

+ UMA_STATUS_AREA_VPN_ADD_BUILT_IN_CLICKED,

+ UMA_STATUS_AREA_VPN_ADD_THIRD_PARTY_CLICKED,

+ UMA_STATUS_AREA_VPN_DISCONNECT_CLICKED,

UMA_STATUS_AREA_VPN_SETTINGS_CLICKED,

UMA_TOGGLE_MAXIMIZE_CAPTION_CLICK,

UMA_TOGGLE_MAXIMIZE_CAPTION_GESTURE,

« no previous file with comments | « ash/ash_chromeos_strings.grdp ('k') | ash/metrics/user_metrics_recorder.cc » ('j') | ash/system/chromeos/network/vpn_list_view.cc » ('J')