ash/metrics/user_metrics_recorder.cc - Issue 980943005: Add ash UI for third-party VPNs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/metrics/user_metrics_recorder.cc

Issue 980943005: Add ash UI for third-party VPNs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@f_2_407541_434711_remove_combined_name

Patch Set: Added a VPNProvider::Key abstraction. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/metrics/user_metrics_recorder.cc

diff --git a/ash/metrics/user_metrics_recorder.cc b/ash/metrics/user_metrics_recorder.cc

index 9fb4e0f1a3c6e0b068c04e31874e58add6302d27..8cfcdce9bdcb9b7eb2da13ebf1a0b732f5d4e71a 100644

--- a/ash/metrics/user_metrics_recorder.cc

+++ b/ash/metrics/user_metrics_recorder.cc

@@ -305,9 +305,15 @@ void UserMetricsRecorder::RecordUserMetricsAction(UserMetricsAction action) {

base::RecordAction(

base::UserMetricsAction("StatusArea_SignOut"));

break;

- case ash::UMA_STATUS_AREA_VPN_JOIN_OTHER_CLICKED:

+ case ash::UMA_STATUS_AREA_VPN_ADD_BUILT_IN_CLICKED:

+ base::RecordAction(base::UserMetricsAction("StatusArea_VPN_AddBuiltIn"));

+ break;

+ case ash::UMA_STATUS_AREA_VPN_ADD_THIRD_PARTY_CLICKED:

base::RecordAction(

- base::UserMetricsAction("StatusArea_VPN_JoinOther"));

+ base::UserMetricsAction("StatusArea_VPN_AddThirdParty"));

+ break;

+ case ash::UMA_STATUS_AREA_VPN_DISCONNECT_CLICKED:

+ base::RecordAction(base::UserMetricsAction("StatusArea_VPN_Disconnect"));

break;

case ash::UMA_STATUS_AREA_VPN_SETTINGS_CLICKED:

base::RecordAction(

« no previous file with comments | « ash/metrics/user_metrics_recorder.h ('k') | ash/resources/ash_resources.grd » ('j') | ash/system/chromeos/network/vpn_list_view.cc » ('J')