Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 980523004: Retain maps embedded in optimized code for several garbage collections. (Closed)

Created:
5 years, 9 months ago by ulan
Modified:
5 years, 9 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Retain maps embedded in optimized code for several garbage collections. This keeps dying maps alive for FLAG_retain_maps_for_n_gc garbage collections to increase chances of them being reused for new objects in future and decrease number of deoptimizations. BUG=v8:3664 LOG=N TEST=cctest/test-heap/MapRetaining Committed: https://crrev.com/1b00451f5748ece669127ce9986ad77e4285bdad Cr-Commit-Position: refs/heads/master@{#27040}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Clear on context disposal #

Total comments: 2

Patch Set 4 : Record slots, do not check constructor #

Patch Set 5 : Rebase and fix #

Patch Set 6 : Check constructor. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -2 lines) Patch
M include/v8.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/heap.h View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 4 4 chunks +15 lines, -0 lines 0 comments Download
M src/heap/mark-compact.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 3 4 5 2 chunks +60 lines, -0 lines 0 comments Download
M src/lithium.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/objects.h View 1 2 3 4 2 chunks +23 lines, -0 lines 0 comments Download
M src/objects.cc View 1 2 3 4 1 chunk +31 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 2 3 4 3 chunks +37 lines, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A test/cctest/test-array-list.cc View 1 chunk +41 lines, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 3 4 6 chunks +36 lines, -1 line 0 comments Download
M test/cctest/test-mark-compact.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ulan
PTAL. This relands parts of CL 794583003. The difference is that we retain only maps ...
5 years, 9 months ago (2015-03-05 12:46:09 UTC) #2
Hannes Payer (out of office)
One nit and please look into the try bot failures. LGTM https://codereview.chromium.org/980523004/diff/40001/src/objects-inl.h File src/objects-inl.h (right): ...
5 years, 9 months ago (2015-03-05 21:12:28 UTC) #3
ulan
Thanks! I fixed bot failure. https://codereview.chromium.org/980523004/diff/40001/src/objects-inl.h File src/objects-inl.h (right): https://codereview.chromium.org/980523004/diff/40001/src/objects-inl.h#newcode2406 src/objects-inl.h:2406: On 2015/03/05 21:12:28, Hannes ...
5 years, 9 months ago (2015-03-06 10:16:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980523004/80002
5 years, 9 months ago (2015-03-06 12:05:26 UTC) #7
commit-bot: I haz the power
Committed patchset #6 (id:80002)
5 years, 9 months ago (2015-03-06 12:36:25 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 12:36:43 UTC) #9
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/1b00451f5748ece669127ce9986ad77e4285bdad
Cr-Commit-Position: refs/heads/master@{#27040}

Powered by Google App Engine
This is Rietveld 408576698